Add registerProtocolHandler tests for FTP.#32739
Open
asankah wants to merge 2 commits into
Open
Conversation
`registerProtocolHandler` allows registering `ftp`, `ftps`, and `sftp` protocols as of whatwg/html#6584. This change adds tests to ensure that `registerProtocolHandler` allows registering those protocols and to ensure that embedded credentials are removed prior to invoking the custom protocol handler.
wpt-pr-bot
requested review from
annevk,
domenic,
foolip,
jdm,
jgraham and
zqzhang
Contributor
Author
|
Note that the |
Contributor
Author
Contributor
Author
|
Ping? |
annevk
approved these changes
Feb 17, 2022
Member
annevk
left a comment
annevk
left a comment
There was a problem hiding this comment.
This looks good to me. I assume you checked that it doesn't change the results in the existing tests?
You might also want to add a test for ftps since I suspect that will be failed by Chrome/Firefox (mainly due to a faulty implementation of the URL parser).
…ject/resources/handler-tools.js Co-authored-by: Anne van Kesteren <annevk@annevk.nl>
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
registerProtocolHandlerallows registeringftp,ftps, andsftpprotocols as of whatwg/html#6584.
This change adds tests to ensure that
registerProtocolHandlerallowsregistering those protocols and to ensure that embedded credentials are
removed prior to invoking the custom protocol handler.