Skip to content

Add registerProtocolHandler tests for FTP. #32739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asankah wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add registerProtocolHandler tests for FTP. #32739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2124091
Add `registerProtocolHandler` tests for FTP.
asankah Feb 7, 2022
67bf9f1
Update html/webappapis/system-state-and-capabilities/the-navigator-ob…
asankah Mar 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions ...and-capabilities/the-navigator-object/protocol-handler-path-credentials-manual.https.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
<!doctype html>
<!-- Tests that embedded credentials are removed when invoking a custom
protocol handler registered via registerProtocolHandler. -->
<meta charset=windows-1254>
<meta name=timeout content=long>
<title>registerProtocolHandler() and a handler with %s in the path</title>
<script src=/resources/testharness.js></script>
<script src=/resources/testharnessreport.js></script>
<script src=/service-workers/service-worker/resources/test-helpers.sub.js></script>
<script>

// Configure expectations for individual test
window.type = "path";
window.noSW = false;
window.scheme = 'ftp';

function runCredentialstest() {
runTest({
credentialsPart: "username:password",
hostPart: "hostname.example"
});
}
</script>
<script src=resources/handler-tools.js></script>
<ol>
<li><p>First, register the handler: <button onclick='register()'>Register</button>.
<li><p>Then, run the test: <button onclick='runCredentialstest()'>Run</button>.
</ol>
<div id=log></div>
4 changes: 3 additions & 1 deletion html/webappapis/system-state-and-capabilities/the-navigator-object/protocol.https.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,6 @@
'cid',
'data',
'file',
'ftp',
'http',
'https',
'javascript',
Expand Down Expand Up @@ -170,6 +169,8 @@
/* safelisted schemes listed in
* https://html.spec.whatwg.org/multipage/system-state.html#safelisted-scheme */
'bitcoin',
'ftp',
'ftps',
'geo',
'im',
'irc',
Expand All @@ -181,6 +182,7 @@
'news',
'nntp',
'openpgp4fpr',
'sftp',
'sip',
'sms',
'smsto',
Expand Down
28 changes: 22 additions & 6 deletions .../webappapis/system-state-and-capabilities/the-navigator-object/resources/handler-tools.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,17 @@ const handler = {
"query": "?QES\u2020QEEPSS%sPSE#FES\u2020FEE",
"fragment": "?QES\u2020QEE#FES\u2020FEEPSS%sPSE"
}[type];
const scheme = `web+wpt${type}${swString}`;

if (!window.hasOwnProperty('scheme')) {
window.scheme = `web+wpt${type}${swString}`;
}

function register() {
const handlerURL = noSW ? `resources/handler.html${handler}${type}` : `resources/handler/${type}/${handler}`;
navigator.registerProtocolHandler(scheme, handlerURL, `WPT ${type} handler${noSW ? ", without service worker" : ""}`);
}

function runTest({ includeNull = false } = {}) {
function runTest({ includeNull = false, credentialsPart = "", hostPart = "" } = {}) {
promise_test(async t => {
const bc = new BroadcastChannel(`protocol-handler-${type}${swString}`);
if (!noSW) {
Expand All @@ -33,15 +36,28 @@ function runTest({ includeNull = false } = {}) {
for (; i < 0x82; i++) {
codePoints.push(String.fromCharCode(i));
}
a.href = `${scheme}:${codePoints.join("")}`;

const targetUrlParts = [
scheme, ":",
hostPart ? "//" : "",
hostPart && credentialsPart ? `${credentialsPart}@` : "",
hostPart ? `${hostPart}/` : "",
codePoints.join("")
];
const expectedUrlParts = [
encodeURIComponent(scheme), "%3A",
hostPart ? `%2F%2F${encodeURIComponent(hostPart)}%2F` : "",
`${includeNull ? "%2500" : ""}%2501%2502%2503%2504%2505%2506%2507%2508%250B%250C%250E%250F%2510%2511%2512%2513%2514%2515%2516%2517%2518%2519%251A%251B%251C%251D%251E%251F%20!%22%23%24%25%26${type === "query" ? "%27" : "'"}()*%2B%2C-.%2F0123456789%3A%3B%3C%3D%3E%3F%40ABCDEFGHIJKLMNOPQRSTUVWXYZ%5B%5C%5D%5E_%60abcdefghijklmnopqrstuvwxyz%7B%7C%7D~%257F%25C2%2580%25C2%2581`
];

a.href = targetUrlParts.join("");
a.target = "_blank";
a.click();
await new Promise(resolve => {
bc.onmessage = t.step_func(e => {
resultingURL = e.data;
assert_equals(stringBetweenMarkers(resultingURL, "QES", "QEE"), "%86", "query baseline");
assert_equals(stringBetweenMarkers(resultingURL, "FES", "FEE"), "%E2%80%A0", "fragment baseline");
assert_equals(stringBetweenMarkers(resultingURL, "PSS", "PSE"), `${encodeURIComponent(scheme)}%3A${includeNull ? "%2500" : ""}%2501%2502%2503%2504%2505%2506%2507%2508%250B%250C%250E%250F%2510%2511%2512%2513%2514%2515%2516%2517%2518%2519%251A%251B%251C%251D%251E%251F%20!%22%23%24%25%26${type === "query" ? "%27" : "'"}()*%2B%2C-.%2F0123456789%3A%3B%3C%3D%3E%3F%40ABCDEFGHIJKLMNOPQRSTUVWXYZ%5B%5C%5D%5E_%60abcdefghijklmnopqrstuvwxyz%7B%7C%7D~%257F%25C2%2580%25C2%2581`, "actual test");
assert_equals(stringBetweenMarkers(resultingURL, "QES", "QEE"), "%86", "query baseline"); assert_equals(stringBetweenMarkers(resultingURL, "FES", "FEE"), "%E2%80%A0", "fragment baseline");
assert_equals(stringBetweenMarkers(resultingURL, "PSS", "PSE"), expectedUrlParts.join(""), "actual test");
resolve();
});
});
Expand Down