layout: Add initial support for first-letter pseudo element#58281
layout: Add initial support for first-letter pseudo element#58281servo-wpt-sync wants to merge 2 commits intoweb-platform-tests:masterfrom
Conversation
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Servo project.
servo-wpt-sync
force-pushed
the
servo_export_43027
branch
from
c914881 to
e2532dd
Compare
Signed-off-by: Minghua Wu <michael.wu1107@gmail.com>
Signed-off-by: Minghua Wu <michael.wu1107@gmail.com>
servo-wpt-sync
force-pushed
the
servo_export_43027
branch
from
e2532dd to
7854a5a
Compare
|
🛠 Changes from the source pull request (servo/servo#43027) can no longer be cleanly applied. Waiting for a new version of these changes downstream. |
10 similar comments
|
🛠 Changes from the source pull request (servo/servo#43027) can no longer be cleanly applied. Waiting for a new version of these changes downstream. |
|
🛠 Changes from the source pull request (servo/servo#43027) can no longer be cleanly applied. Waiting for a new version of these changes downstream. |
|
🛠 Changes from the source pull request (servo/servo#43027) can no longer be cleanly applied. Waiting for a new version of these changes downstream. |
|
🛠 Changes from the source pull request (servo/servo#43027) can no longer be cleanly applied. Waiting for a new version of these changes downstream. |
|
🛠 Changes from the source pull request (servo/servo#43027) can no longer be cleanly applied. Waiting for a new version of these changes downstream. |
|
🛠 Changes from the source pull request (servo/servo#43027) can no longer be cleanly applied. Waiting for a new version of these changes downstream. |
|
🛠 Changes from the source pull request (servo/servo#43027) can no longer be cleanly applied. Waiting for a new version of these changes downstream. |
|
🛠 Changes from the source pull request (servo/servo#43027) can no longer be cleanly applied. Waiting for a new version of these changes downstream. |
|
🛠 Changes from the source pull request (servo/servo#43027) can no longer be cleanly applied. Waiting for a new version of these changes downstream. |
|
🛠 Changes from the source pull request (servo/servo#43027) can no longer be cleanly applied. Waiting for a new version of these changes downstream. |
3 participants
This and the accompanying stylo PR (servo/stylo#320) is a partial implementation of the
first-letterpseudo element. The current implementation doesn't supportfloatand nesting/inheritance (see spec https://drafts.csswg.org/css-pseudo/#first-letter-tree). These will be supported in future PRs.Because the first letter would be split into a separate
InlineItemfrom the rest of the text, this PR introduces a hack (zero-width joiner codepoint) to address the problem where letters would be written differently when joined together in some languages like Arabic. This hack currently only checks if the language tag is"ar"or"fa"as I have limited knowledge on such writing systems. A proper solution for this is needed.Testing: Existing WPT tests. There is one WPT test (fcp-typographic-pseudo.html) that servo currently fails would timeout with this PR because nesting/inheritance is not well supported in this PR.
Fixes: #43008
Part of: #15413
Reviewed in servo/servo#43027