Enabling parsing first-letter pseudo element for servo#320
Merged
Loirooriol merged 6 commits intoservo:mainfrom Mar 11, 2026
Merged
Enabling parsing first-letter pseudo element for servo#320Loirooriol merged 6 commits intoservo:mainfrom
first-letter pseudo element for servo#320Loirooriol merged 6 commits intoservo:mainfrom
Conversation
Collaborator
|
Please rebase this, you are including commits from other PRs. |
minghuaw
force-pushed
the
feat/first-letter
branch
from
d6494fb to
dc0726b
Compare
Contributor
Author
Thanks! Rebased |
minghuaw
force-pushed
the
feat/first-letter
branch
from
dc0726b to
69b55e9
Compare
Loirooriol
reviewed
Mar 7, 2026
Contributor
Author
|
@Loirooriol Addressed the comments in 65ed94c. Would you mind taking a look at the servo PR as well? It's much simplified after addressing Xiaocheng's comment |
Loirooriol
changed the title
first-letter psuedo element for servofirst-letter pseudo element for servo
Loirooriol
force-pushed
the
feat/first-letter
branch
from
6aa0d5d to
5a11443
Compare
minghuaw
force-pushed
the
feat/first-letter
branch
from
5a11443 to
643db54
Compare
Signed-off-by: Minghua Wu <michael.wu1107@gmail.com>
Signed-off-by: Minghua Wu <michael.wu1107@gmail.com>
Signed-off-by: Minghua Wu <michael.wu1107@gmail.com>
minghuaw
force-pushed
the
feat/first-letter
branch
from
643db54 to
80316b5
Compare
Loirooriol
approved these changes
Mar 10, 2026
Comment on lines
+281
to
+285
| @@ -279,6 +282,7 @@ impl PseudoElement { | |||
| PropertyFlags::APPLIES_TO_MARKER | |||
| }, | |||
| PseudoElement::Placeholder => PropertyFlags::APPLIES_TO_PLACEHOLDER, | |||
| PseudoElement::FirstLetter => PropertyFlags::APPLIES_TO_FIRST_LETTER, | |||
Collaborator
There was a problem hiding this comment.
Ditto
PseudoElement::FirstLetter => PropertyFlags::APPLIES_TO_FIRST_LETTER,
PseudoElement::Marker if static_prefs::pref!("layout.css.marker.restricted") => {
PropertyFlags::APPLIES_TO_MARKER
},
PseudoElement::Placeholder => PropertyFlags::APPLIES_TO_PLACEHOLDER,Co-authored-by: Oriol Brufau <obrufau@igalia.com> Signed-off-by: minghuaw <michael.wu1107@gmail.com>
Signed-off-by: Minghua Wu <michael.wu1107@gmail.com>
Contributor
Author
|
@Loirooriol All checks (including WPT: https://github.com/servo/servo/actions/runs/22933642417) in the accompanying servo PR have passed |
github-merge-queue Bot
pushed a commit
to servo/servo
that referenced
this pull request
Mar 11, 2026
This and the accompanying stylo PR (servo/stylo#320) is a partial implementation of the `first-letter` pseudo element. Testing: Existing WPT tests. There is one WPT test (fcp-typographic-pseudo.html) that servo currently fails would timeout with this PR because opacity of `TextFragment` is taken from the `InlineFormattingContext` instead of the pseudo element. Fixes: #43008 Part of: #15413 --------- Signed-off-by: Minghua Wu <michael.wu1107@gmail.com> Signed-off-by: minghuaw <michael.wu1107@gmail.com> Signed-off-by: Oriol Brufau <obrufau@igalia.com> Co-authored-by: Xiaocheng Hu <xiaochengh.work@gmail.com> Co-authored-by: Oriol Brufau <obrufau@igalia.com>
github-merge-queue Bot
pushed a commit
to servo/servo
that referenced
this pull request
Mar 11, 2026
This and the accompanying stylo PR (servo/stylo#320) is a partial implementation of the `first-letter` pseudo element. Testing: Existing WPT tests. There is one WPT test (fcp-typographic-pseudo.html) that servo currently fails would timeout with this PR because opacity of `TextFragment` is taken from the `InlineFormattingContext` instead of the pseudo element. Fixes: #43008 Part of: #15413 --------- Signed-off-by: Minghua Wu <michael.wu1107@gmail.com> Signed-off-by: minghuaw <michael.wu1107@gmail.com> Signed-off-by: Oriol Brufau <obrufau@igalia.com> Co-authored-by: Xiaocheng Hu <xiaochengh.work@gmail.com> Co-authored-by: Oriol Brufau <obrufau@igalia.com>
lando-worker Bot
pushed a commit
to mozilla-firefox/firefox
that referenced
this pull request
Apr 3, 2026
… r=firefox-style-system-reviewers,dshin,emilio Imports servo/stylo#320 Differential Revision: https://phabricator.services.mozilla.com/D291909
github-actions Bot
pushed a commit
to longvatrong111/stylo
that referenced
this pull request
Apr 4, 2026
… r=firefox-style-system-reviewers,dshin,emilio Imports servo#320 Differential Revision: https://phabricator.services.mozilla.com/D291909
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables parsing
first-letterpseudo element for servo. An accompanying servo PR (servo/servo#43027) is open