layout: Add initial support for first-letter pseudo element#58348
Closed
servo-wpt-sync wants to merge 4 commits intoweb-platform-tests:masterfrom
Closed
layout: Add initial support for first-letter pseudo element#58348servo-wpt-sync wants to merge 4 commits intoweb-platform-tests:masterfrom
servo-wpt-sync wants to merge 4 commits intoweb-platform-tests:masterfrom
Conversation
wpt-pr-bot
approved these changes
Mar 7, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Servo project.
servo-wpt-sync
force-pushed
the
servo_export_43027
branch
15 times, most recently
from
cd87abf to
b174056
Compare
Signed-off-by: Minghua Wu <michael.wu1107@gmail.com>
Signed-off-by: Minghua Wu <michael.wu1107@gmail.com>
Signed-off-by: minghuaw <michael.wu1107@gmail.com>
Signed-off-by: Minghua Wu <michael.wu1107@gmail.com>
servo-wpt-sync
force-pushed
the
servo_export_43027
branch
from
b174056 to
1991a82
Compare
Collaborator
Author
|
👋 Downstream pull request (servo/servo#43027) no longer contains any upstreamable changes. Closing pull request without merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This and the accompanying stylo PR (servo/stylo#320) is a partial implementation of the
first-letterpseudo element. The current implementation doesn't supportfloatand nesting/inheritance (see spec https://drafts.csswg.org/css-pseudo/#first-letter-tree). These will be supported in future PRs.Because the first letter would be split into a separate
InlineItemfrom the rest of the text, this PR introduces a hack (zero-width joiner codepoint) to address the problem where letters would be written differently when joined together in some languages like Arabic. This hack currently only checks if the language tag is"ar"or"fa"as I have limited knowledge on such writing systems. A proper solution for this is needed.Testing: Existing WPT tests. There is one WPT test (fcp-typographic-pseudo.html) that servo currently fails would timeout with this PR because nesting/inheritance is not well supported in this PR.
Fixes: #43008
Part of: #15413
Reviewed in servo/servo#43027