docs(guides): update against webpack 5#4099
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/webpack-docs/webpack-js-org/dye45qavw |
|
I found It's very difficult to maintain those diff blocks, any suggestion? So far I've maintained a repository here https://github.com/chenxsan/webpack-demo and copy/paste those diff manually. Update
|
|
I'll continue this PR after it's fixed. |
|
@chenxsan Can you open an issue in |
| } | ||
| }; | ||
| ```diff | ||
| const path = require('path'); |
There was a problem hiding this comment.
This is inverted, path is the new line added.
| console.log(json.title); // output `JSON5 Example` | ||
| console.log(json.owner.name); // output `Tom Preston-Werner` | ||
| ```diff | ||
| import Icon from './icon.png'; |
There was a problem hiding this comment.
Also inverted, Icon, Data and Notes are new lines.
|
|
||
| ``` diff | ||
| const path = require('path'); | ||
| const HtmlWebpackPlugin = require('html-webpack-plugin'); |
| + "watch": "webpack --watch", | ||
| "build": "webpack" | ||
| }, | ||
| "repository": { |
There was a problem hiding this comment.
Better to keep the entire diff.
|
I'm dropping this PR in favor of other smaller ones as this one will be a larger one making it difficult to review. |
4 participants
closes #4090 fixes #4098
Guidesection needs to be updated against webpack 5, I'll do it in this pull request.PREVIEW URL: https://webpack-js-org-git-feature-update-guide-against-webpack5.webpack-docs.vercel.app/guides/getting-started/