docs(guides): update getting-started against webpack 5#4134
Merged
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/webpack-docs/webpack-js-org/pk09tp8so |
This was referenced Nov 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found it would be difficult to review all those changes in one pull request like #4099, thus I'm splitting it into small ones. Hopefully we can alleviate the pain of reviewing a lot.
Regarding those diff blocks, I'm using Prettier to format code first, and
git show --no-prefix -U1000 > patch.diffto generate the diffs. It brought quite a lot of changes to the code blocks which is a pain for reviewer at the moment, but I think these changes are beneficial for future as contributors can share the same tools when updating guides with diff blocks. Before this I have to do it manually as there's no guide how to do it, which is inefficient and error-prone.Related code repository
https://github.com/chenxsan/webpack-demo
PREVIEW
https://webpack-js-org-git-feature-update-getting-started.webpack-docs.vercel.app/guides/getting-started/