feature: expose GalleryItem#6
Merged
Merged
Conversation
Member
|
This works for me! Thanks for the update. Do you mind updating the docs as well? No rush. If this is not urgent, I think we should prep a release before merging this to main, which also includes a fix to #3. |
andrewrubin
requested changes
Jul 12, 2023
andrewrubin
reviewed
Jul 12, 2023
c968d7a to
5aff3eb
Compare
andrewrubin
approved these changes
Jul 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Right now there is no way to target the
<li>item that is auto generated and wrapped around the render function. So trying to customize it while using CSS modules require the use of the:globalmixin.The goal of this PR is to expose the
<GalleryItem />component to allow for further customization of the automatically rendered<li>tag.This is a breaking change so I bumped the version to
2.0.0.Usage
Not much changes, only things is that now users need to return a
<GalleryItem />component inside their render function: