Skip to content

fix: update useModal args to be optional#64

Merged
marlonmarcello merged 1 commit into
release/v3.0.0from
feature/add-optional-hook-args
Jul 30, 2024
Merged

fix: update useModal args to be optional#64
marlonmarcello merged 1 commit into
release/v3.0.0from
feature/add-optional-hook-args

Conversation

@wonderfulfrog
Copy link
Copy Markdown
Contributor

Description

This PR updates the props argument of useModal to default to an empty object when not provided any arguments.

Fixes #62.

Solution

This change makes it a little bit easier to use the package and follows the doc examples.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jul 29, 2024

⚠️ No Changeset found

Latest commit: a3cfd24

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

marlonmarcello
marlonmarcello previously approved these changes Jul 29, 2024
@andrewrubin
Copy link
Copy Markdown
Member

Let's get a release branch going for this, as Clinton has some API updates as well. We can regroup on that tomorrow! @marlonmarcello @wonderfulfrog

@andrewrubin
Copy link
Copy Markdown
Member

Opened #65 , if you don't mind @wonderfulfrog, please change the base branch for this PR to that one! 🙏

@wonderfulfrog wonderfulfrog changed the base branch from main to release/v3.0.0 July 30, 2024 16:47
@wonderfulfrog wonderfulfrog dismissed marlonmarcello’s stale review July 30, 2024 16:47

The base branch was changed.

@wonderfulfrog
Copy link
Copy Markdown
Contributor Author

@andrewrubin Done! Changed to release/v3.0.0.

@marlonmarcello marlonmarcello merged commit 49a1c9e into release/v3.0.0 Jul 30, 2024
@marlonmarcello marlonmarcello deleted the feature/add-optional-hook-args branch July 30, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mark argument of the hook as optional

3 participants