Release: v3.0.0#65
Merged
Merged
Conversation
…MLElement and updated test modals
…pdated variable name
…nd only accept HTMLElement
🦋 Changeset detectedLatest commit: 789ab3a The changes in this PR will be included in the next version bump. This PR includes no changesetsWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Feature: Added renderTo prop instead of appendToBody
marlonmarcello
approved these changes
Jul 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release: v3.0.0
Time tracking: https://wethecollective.teamwork.com/app/tasks/22769488
Description
This PR adds an API change to the
<Modal>component, such that it removes theappendToBodyboolean prop, and adds anappendToprop, which expects an HTMLElement.appendTois required.This also fixes a bug in which the
useModalhook had to have an input in order to work properly. The default input is now an empty object{}.Does this close any open issues?
appendToBodyin favour of arenderToprop that allows a selector or DOMNode to be passed #20