Skip to content

add support for multiple signature keys#209

Merged
willnorris merged 2 commits into
willnorris:masterfrom
maurociancio:multiple-signature-key
Feb 2, 2020
Merged

add support for multiple signature keys#209
willnorris merged 2 commits into
willnorris:masterfrom
maurociancio:multiple-signature-key

Conversation

@maurociancio
Copy link
Copy Markdown
Contributor

Add support to have multiple signature key, according to #206 .

This is useful to rotate keys without breaking existing clients.

@googlebot
Copy link
Copy Markdown
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@maurociancio
Copy link
Copy Markdown
Contributor Author

maurociancio commented Dec 30, 2019

@googlebot I signed it

@googlebot
Copy link
Copy Markdown
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Copy Markdown
Owner

@willnorris willnorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great... I love how simple it turned out. A few minor, mostly stylistic, comments below. I'm happy to make these changes myself before merging, but given how long it's taking me to do reviews, that might take longer :)

Comment thread cmd/imageproxy/main.go Outdated
Comment thread imageproxy.go Outdated
Comment thread imageproxy.go Outdated
Comment thread imageproxy.go Outdated
Comment thread imageproxy_test.go Outdated
@willnorris willnorris merged commit ef09c1b into willnorris:master Feb 2, 2020
@maurociancio
Copy link
Copy Markdown
Contributor Author

Thanks for merging!

vetler pushed a commit to vetler/imageproxy that referenced this pull request Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants