fix(blueprint): Wait for kustomizations to complete and their resources to terminate #1509
+334
−584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es to terminate We were previously not properly waiting for resources to terminate as expected. This change will both wait for cleanup kustomizations to complete, and wait for termination of resources when kustomizations are deleted.
Implements improved mechanics for cleaning up resources during windsor down. Previously, we were not truly waiting for resources or kustomizations to be completely destroyed before moving on.
rmvangun
force-pushed
the
fix/wait-for-termination-cleanup
branch
from
a741b73 to
01d8703
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were previously not properly waiting for resources to terminate as expected. This change will both wait for cleanup kustomizations to complete, and wait for termination of resources when kustomizations are deleted.