Skip to content

fix(blueprint): Wait for kustomizations to complete and their resources to terminate #1509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rmvangun merged 2 commits into from
Jul 27, 2025
Merged

fix(blueprint): Wait for kustomizations to complete and their resources to terminate #1509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4380efb
fix(blueprint): Wait for kustomizations to complete and their resourc…
rmvangun Jul 26, 2025
01d8703
fix(cleanup): Wait for kustomizations to cleanup
rmvangun Jul 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions api/v1alpha1/blueprint_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,10 @@ type Kustomization struct {

// PostBuild is a post-build step to run after the kustomization is applied.
PostBuild *PostBuild `yaml:"postBuild,omitempty"`

// Destroy determines if the kustomization should be destroyed during down operations.
// Defaults to true if not specified.
Destroy *bool `yaml:"destroy,omitempty"`
}

// PostBuild is a post-build step to run after the kustomization is applied.
Expand Down Expand Up @@ -414,5 +418,6 @@ func (k *Kustomization) DeepCopy() *Kustomization {
Components: slices.Clone(k.Components),
Cleanup: slices.Clone(k.Cleanup),
PostBuild: postBuildCopy,
Destroy: k.Destroy,
}
}
5 changes: 5 additions & 0 deletions cmd/down.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ var (
cleanFlag bool
skipK8sFlag bool
skipTerraformFlag bool
skipDockerFlag bool
)

var downCmd = &cobra.Command{
Expand Down Expand Up @@ -63,6 +64,9 @@ var downCmd = &cobra.Command{
if skipTerraformFlag {
ctx = context.WithValue(ctx, "skipTerraform", true)
}
if skipDockerFlag {
ctx = context.WithValue(ctx, "skipDocker", true)
}

// Execute the down pipeline
if err := downPipeline.Execute(ctx); err != nil {
Expand All @@ -77,5 +81,6 @@ func init() {
downCmd.Flags().BoolVar(&cleanFlag, "clean", false, "Clean up context specific artifacts")
downCmd.Flags().BoolVar(&skipK8sFlag, "skip-k8s", false, "Skip Kubernetes cleanup (blueprint cleanup)")
downCmd.Flags().BoolVar(&skipTerraformFlag, "skip-tf", false, "Skip Terraform cleanup")
downCmd.Flags().BoolVar(&skipDockerFlag, "skip-docker", false, "Skip Docker container cleanup")
rootCmd.AddCommand(downCmd)
}
Loading
Loading