feat(blueprint): Add CEL feature evaluator #1668
Closed
+539
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the feature evaluator to the blueprint package. This leverages the CEL system to evaluate conditionals for eventual feature composition of blueprints.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is the final PR Bugbot will review for you during this billing cycle
Your free Bugbot reviews will reset on October 14
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
|
|
||
| return &FeatureEvaluator{ | ||
| env: env, | ||
| }, nil |
There was a problem hiding this comment.
Bug: Redundant Initialization in FeatureEvaluator
The FeatureEvaluator initializes a cel.Env in its constructor, but this env field is never used. Instead, the CompileExpression method creates a new cel.Env from scratch on each call, making the constructor's initialization redundant.
Additional Locations (1)
Contributor
Author
|
Closed in favor of #1670 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the feature evaluator to the blueprint package. This leverages the CEL system to evaluate conditionals for eventual feature composition of blueprints.