Fix 1Password multi-vault malfunction #796
Merged
+63
−210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
rmvangun
deleted the
ENG-294_Fix-for-malfunction-involving-two-1Password-vaults
branch
rmvangun
added a commit
that referenced
this pull request
Mar 17, 2025
* Remove breaks so providers are created * go deps * Only parse secrets belonging to the provider * Improve regex * Add test
rmvangun
added a commit
that referenced
this pull request
Mar 31, 2025
* Remove breaks so providers are created * go deps * Only parse secrets belonging to the provider * Improve regex * Add test tidy
rmvangun
restored the
ENG-294_Fix-for-malfunction-involving-two-1Password-vaults
branch
rmvangun
added a commit
that referenced
this pull request
Apr 12, 2025
* Remove breaks so providers are created * go deps * Only parse secrets belonging to the provider * Improve regex * Add test tidy
rmvangun
added a commit
that referenced
this pull request
Apr 12, 2025
* Remove breaks so providers are created * go deps * Only parse secrets belonging to the provider * Improve regex * Add test tidy
rmvangun
added a commit
that referenced
this pull request
Apr 12, 2025
* Add op_sdk_secrets_provider * Fix 1Password multi-vault malfunction (#796) * Remove breaks so providers are created * go deps * Only parse secrets belonging to the provider * Improve regex * Add test tidy
rmvangun
added a commit
that referenced
this pull request
Apr 23, 2025
* Remove breaks so providers are created * go deps * Only parse secrets belonging to the provider * Improve regex * Add test tidy
rmvangun
added a commit
that referenced
this pull request
Apr 23, 2025
* Add op_sdk_secrets_provider * Fix 1Password multi-vault malfunction (#796) * Remove breaks so providers are created * go deps * Only parse secrets belonging to the provider * Improve regex * Add test tidy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 1Password CLI provider was malfunctioning when multiple vaults were configured. The secrets were reporting as not found.
There were two problems. First, the use of
breakmade us stop continuing to parse more than the first secret found.An additional error was triggered as it was attempting to parse secrets for vaults that didn't match.
We now make sure to only attempt to parse secrets for matching vault IDs.
Also uses a more robust regex for matching onepassword secrets.