Fix 1Password multi-vault malfunction #946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

rmvangun wants to merge 127 commits into main from ENG-294_Fix-for-malfunction-involving-two-1Password-vaults

+5,313 −2,120

Contributor

rmvangun commented Apr 4, 2025

Note: This is a second round of #796 , as it was unintentionally reverted.

The 1Password CLI provider was malfunctioning when multiple vaults were configured. The secrets were reporting as not found.

There were two problems. First, the use of break made us stop continuing to parse more than the first secret found.

An additional error was triggered as it was attempting to parse secrets for vaults that didn't match.

We now make sure to only attempt to parse secrets for matching vault IDs.

Also uses a more robust regex for matching onepassword secrets.

rmvangun and others added 30 commits

February 22, 2025 18:03


          Fix localstack pro image (#669)

460e9d2


          Auto-configure AWS config for localstack (#670)

6dea6d5

* Add aws config generator

* gosec

* gosec

* gosec

* go mod

* Fix tests on windows


          Update dependency aquaproj/aqua-registry to v4.319.2 (#672)

3b122a0

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update dependency aquaproj/aqua-renovate-config to v2.7.5 (#673)

741a723

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update dependency aquaproj/aqua to v2.45.0 (#674)

1fbaee7

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Generate AWS terraform provider override when localstack is enabled (#…

7a2f103

…671)

* Generate provider_override.tf

* Generate provider_override.tf

* Add invalid terraform service names

* skip requesting account id


          Windsor docker image (#675)

4414cac

* Fix renovate to track Dockerfile

* Add windsor docker image

* Improve renovate regex match


          Update ghcr.io/siderolabs/talos Docker tag to v1.9.4 (#676)

4752eda

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update coredns/coredns Docker tag to v1.12.0 (#677)

37c7fb4

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update google.golang.org/genproto digest to 546df14 (#679)

b6c1df3

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update module github.com/go-jose/go-jose/v4 to v4.0.5 [SECURITY] (#681)

866458b

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update google.golang.org/genproto/googleapis/api digest to 546df14 (#680

c5a57a6

)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update google.golang.org/genproto/googleapis/rpc digest to 546df14 (#682

a5e5b5d

)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update dependency aws/aws-cli to v2.24.11 (#683)

152f682

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update dependency fluxcd/flux2 to v2.5.1 (#686)

2cf20b6

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update dependency aws/aws-cli to v2.24.12 (#687)

e0e26ed

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update module github.com/fluxcd/kustomize-controller/api to v1.5.1 (#688

fc4caea

)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update dependency aquaproj/aqua-registry to v4.320.0 (#684)

5c6dd71

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Sign binaries (#678)

4f0b4ca

* gorelease-updates

* updated format


          Update module github.com/emicklei/go-restful/v3 to v3.12.2 (#690)

2d159eb

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update dependency aquaproj/aqua-registry to v4.321.0 (#691)

74b3c62

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update dependency aws/aws-cli to v2.24.13 (#692)

c3ea5a9

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update dependency siderolabs/omni/omnictl to v0.47.0 (#685)

c8c9782

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update docker/build-push-action action to v6.15.0 (#693)

653face

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update module github.com/ProtonMail/go-crypto to v1.1.6 (#695)

a099d9f

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update dependency hashicorp/terraform to v1.11.0 (#696)

68661d1

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update actions/cache action to v4.2.2 (#697)

2f60340

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update aws-sdk-go-v2 monorepo (#698)

f0e4e93

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update google.golang.org/genproto digest to 55c9018 (#699)

ce6f69f

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update google.golang.org/genproto/googleapis/api digest to 55c9018 (#700

cf9cf91

)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

renovate bot and others added 25 commits

March 13, 2025 21:44


          Update go-openapi packages (#774)

d6d40b8

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update google.golang.org/genproto digest to e70fdf4 (#780)

7b4a087

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update google.golang.org/genproto/googleapis/api digest to e70fdf4 (#781

96f51ed

)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update google.golang.org/genproto/googleapis/rpc digest to e70fdf4 (#782

cfaf70c

)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update dependency aws/aws-cli to v2.24.23 (#783)

d0f36bd

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update dependency helm/helm to v3.17.2 (#784)

8dcf1ae

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update kubernetes packages to v0.32.3 (#775)

29d155b

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update dependency aws/aws-cli to v2.24.24 (#786)

580895f

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update module cloud.google.com/go/iam to v1.4.2 (#785)

8e9868e

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update module cloud.google.com/go/kms to v1.21.1 (#787)

73f3216

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update module cloud.google.com/go/longrunning to v0.6.6 (#788)

f747bcb

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update module cloud.google.com/go/monitoring to v1.24.1 (#789)

108f0d5

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update module github.com/googleapis/enterprise-certificate-proxy to v…

a3d1bc9

…0.3.6 (#790)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update dependency docker/compose to v2.34.0 (#791)

709a05b

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update dependency goreleaser/goreleaser to v2.8.1 (#778)

eaf7d1d

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update docker/login-action action to v3.4.0 (#792)

b044546

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update dependency aquaproj/aqua-registry to v4.327.0 (#794)

2559eb8

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update module cloud.google.com/go to v0.119.0 (#768)

de9093c

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Update module cloud.google.com/go/storage to v1.51.0 (#779)

b4ed453

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>


          Remove breaks so providers are created

709e4a3


          Merge branch 'main' into ENG-294_Fix-for-malfunction-involving-two-1P…

fe01d0e

…assword-vaults


          go deps

e71b97a


          Only parse secrets belonging to the provider

dc48d65


          Improve regex

d27b40a


          Add test

c3e51a0

rmvangun added the bug label

Contributor Author

rmvangun commented Apr 4, 2025

Task linked: ENG-294 Fix for malfunction involving two 1Password vaults


          Merge branch 'main' into ENG-294_Fix-for-malfunction-involving-two-1P…

c400e5c

…assword-vaults

rmvangun closed this

rmvangun deleted the ENG-294_Fix-for-malfunction-involving-two-1Password-vaults branch

April 4, 2025 20:12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug