Skip to content

Comments

Remove max-depth restriction from getAvailablePaths#148

Merged
LukeTowers merged 1 commit intodevelopfrom
fix/limited-cache-paths
May 29, 2023
Merged

Remove max-depth restriction from getAvailablePaths#148
LukeTowers merged 1 commit intodevelopfrom
fix/limited-cache-paths

Conversation

@jaxwilko
Copy link
Member

This PR removes the limit put in place in #135 in order to fix wintercms/wn-blocks-plugin#6.

From memory, I believe not restricting the path cache caused issues when using a combination of child themes and blocks which lead to a theme datasource structure of:

AutoDatasource: 
    - AutoDatasource:
        - FileDatasource - child
        - FileDatasource - parent
    - BlocksDatasourcce

image

However after some testing I was not able to reproduce the error, therefore this PR reverts the change.

@LukeTowers LukeTowers added this to the v1.2.2 milestone May 29, 2023
@LukeTowers LukeTowers merged commit e228543 into develop May 29, 2023
@LukeTowers LukeTowers deleted the fix/limited-cache-paths branch May 29, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using partials in deeply folders structure

2 participants