Ensure that getAvailablePaths respects the maxDepth of the file iterator#135
Merged
LukeTowers merged 2 commits intodevelopfrom Dec 12, 2022
Merged
Conversation
|
LukeTowers
reviewed
Dec 9, 2022
LukeTowers
reviewed
Dec 9, 2022
LukeTowers
approved these changes
Dec 12, 2022
LukeTowers
pushed a commit
that referenced
this pull request
May 29, 2023
Removes the limit put in place in #135 in order to fix wintercms/wn-blocks-plugin#6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue brought to light by wintercms/winter#791.
When
FileDatasource::getAvailablePaths()is called, it does not respect the same maxDepth setting that is set inFileDatasource::select()meaning that the reported paths differ from the selectable paths.This PR adds the
setMaxDepth()call on the iterator used ingetAvailablePaths()and sets a property formaxDepthto remove magic numbers and allow for custom extensions.