[FIX] Added fix to allow nested AutoDatasource instances to manage their own populateCache#791
Merged
LukeTowers merged 9 commits intowip/child-themefrom Dec 13, 2022
Conversation
If gtag() is undefined an error is raised.
Refs: - https://wintercms.com/docs/snowboard/extras#ajax-validation - Workshop Theme examples: wintercms/wn-workshop-theme@431e761
The CommonMark implementation of Markdown specifies that a newline should follow block-level elements
This took inspiration from https://github.com/hasinhayder/vue3-icon-picker but was modified greatly in the end. Credit to @robertalexa
|
Member
|
@jaxwilko the tests are more relevant now, can you fix it? |
Member
Author
Yeah, so the issue is not caused by this PR, but just becomes apparent because of it. The fix for the issue is here: wintercms/storm#135 |
LukeTowers
added
Status: Completed
maintenance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a fix to support nested
AutoDatasourceinstances. The issue with nesting anAutoDatasourceinside anAutoDatasourceis that thepopulateCache()method would not proxy the call to the nested instance and instead force the caching against theAutoDatasourceinstead of the child Datasource instances, this would mean that cache would not be correctly invalidated and after issuinginsert,updateordeleterequests the parent cache would be updated but the instance cache would not be.This change allows the
populateCache()request to be passed into the nestedAutoDatasourceto allow for recursive behaviour.