Fix return type hints for CMS Page and Controller.#362
Merged
LukeTowers merged 1 commit intowintercms:developfrom Nov 30, 2021
ericp-mrel:fix/typehints
Merged
Fix return type hints for CMS Page and Controller.#362LukeTowers merged 1 commit intowintercms:developfrom ericp-mrel:fix/typehints
LukeTowers merged 1 commit intowintercms:developfrom
ericp-mrel:fix/typehints
Conversation
LukeTowers
added
Status: Completed
maintenance
LukeTowers
added a commit
that referenced
this pull request
Dec 9, 2021
* develop: (90 commits) Define signature for "defineProperties" method Add definition of "componentDetails" method Update `system` french lang files (#366) Update `backend` french lang file (#364) Update `cms` french lang file (#365) Fix clear color picker function, allow empty value Trigger "change" event on color picker when value changes Use better cursors for readonly color picker Adjust "force" option for plugin:remove Require explicit confirmations for CLI deletions Add PHP 8.1 option, drop other details field Add md_line Twig filter to expose Markdown::parseLine() (#370) Don't use the Cache facade in the service provider registration process. Fix return type hints for CMS Page and Controller (#362) Fixes typo in list of available encodings for importing Improved Ukrainian translation (#360) Constrain PHP version >= 7.2.9 and 8.0.x (#361) Improve Latvian translation (#358) Docs UI Fix paths to screenshots of diagrams (#359) Coerce Inspector set values to string ... # Conflicts: # composer.json # modules/backend/composer.json # modules/cms/composer.json # modules/system/composer.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a couple of type hints I came across which didn't include null as a possible return type.