Skip to content

Fix return type hints for CMS Page and Controller. #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LukeTowers merged 1 commit into from
Nov 30, 2021
Merged

Fix return type hints for CMS Page and Controller. #362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions modules/cms/classes/Controller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1336,7 +1336,7 @@ public function getLayout()
* @param mixed $name Specifies the Cms Page file name.
* @param array $parameters Route parameters to consider in the URL.
* @param bool $routePersistence By default the existing routing parameters will be included
* @return string
* @return string|null
*/
public function pageUrl($name, $parameters = [], $routePersistence = true)
{
Expand Down Expand Up @@ -1519,7 +1519,7 @@ public function findComponentByHandler($handler)
/**
* Searches the layout and page components by a partial file
* @param string $partial
* @return ComponentBase The component object, if found
* @return ComponentBase|null The component object, if found
*/
public function findComponentByPartial($partial)
{
Expand Down
2 changes: 1 addition & 1 deletion modules/cms/classes/Page.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ public static function getNameList()
* Helper that makes a URL for a page in the active theme.
* @param mixed $page Specifies the Cms Page file name.
* @param array $params Route parameters to consider in the URL.
* @return string
* @return string|null
*/
public static function url($page, array $params = [])
{
Expand Down