Can't pass null to non-nullable arguments#524
Closed
Denoder wants to merge 5 commits intowintercms:wip/1.2from
Closed
Can't pass null to non-nullable arguments#524Denoder wants to merge 5 commits intowintercms:wip/1.2from
Denoder wants to merge 5 commits intowintercms:wip/1.2from
Conversation
added 2 commits
April 4, 2022 20:12
This is in regards to: https://wiki.php.net/rfc/deprecate_null_to_scalar_internal_arg I'm getting this deprecation warning throughout all of winter with php 8.1 and it's happening in both winter and storm
LukeTowers
reviewed
Apr 5, 2022
LukeTowers
added
maintenance
Denoder
pushed a commit
to Denoder/storm
that referenced
this pull request
Apr 12, 2022
extension of: wintercms/winter#524 There should be a better way of handling this.
added 2 commits
April 12, 2022 01:14
Member
|
@teranode are you still getting those warnings? If so, where and how? I'm running 8 projects on latest wip/1.2 and have not seen those. |
Contributor
Author
|
I went back to php8.0 cause the errors were getting pretty annoying, so Idk if it's still happening, I'll check tomorrow to see if it's still occurring |
LukeTowers
pushed a commit
to wintercms/storm
that referenced
this pull request
Jul 9, 2022
Member
|
@teranode if you could check to see if this is still a problem without your changes and then resubmit the PR if it is that would be great; thanks! |
LukeTowers
added
needs response
Contributor
Author
|
@LukeTowers yes it is still happening with php 8.1
|
Contributor
Author
|
There's also this one, I've not seen any indication of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in regards to: https://wiki.php.net/rfc/deprecate_null_to_scalar_internal_arg
I'm getting this deprecation warning throughout all of winter with php 8.1 and it's happening in both winter and storm