Skip to content

Can't pass null to non-nullable arguments #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Denoder wants to merge 5 commits into from
Closed

Can't pass null to non-nullable arguments #524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b34df4a
Can't pass null to non-nullable arguments
teranode Apr 5, 2022
64361ec
Update _settings_menu_items.htm
teranode Apr 5, 2022
0273c9f
Update Filter.php
teranode Apr 12, 2022
3c6329b
Update DateTime.php
teranode Apr 12, 2022
283cb6c
Update SettingsManager.php
teranode Apr 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions modules/backend/widgets/Filter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -687,8 +687,8 @@ public function removeScope($scopeName)
*/
protected function makeFilterScope($name, $config)
{
$label = $config['label'] ?? null;
$scopeType = $config['type'] ?? null;
$label = $config['label'] ?? '';
$scopeType = $config['type'] ?? '';

$scope = new FilterScope($name, $label);
$scope->displayAs($scopeType, $config);
Expand Down
2 changes: 1 addition & 1 deletion modules/backend/widgets/Lists.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -926,7 +926,7 @@ protected function makeListColumn($name, $config)
$config['searchable'] = false;
}

$columnType = $config['type'] ?? null;
$columnType = $config['type'] ?? '';

$column = new ListColumn($name, $label);
$column->displayAs($columnType, $config);
Expand Down
2 changes: 1 addition & 1 deletion modules/system/classes/SettingsManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@ public function getContext()
{
return (object) [
'itemCode' => $this->contextItemCode,
'owner' => strtolower($this->aliases[$this->contextOwner] ?? $this->contextOwner),
'owner' => strtolower($this->aliases[$this->contextOwner] ?? ($this->contextOwner ?? '')),
];
}

Expand Down
2 changes: 1 addition & 1 deletion modules/system/helpers/DateTime.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,6 @@ public static function momentFormat($format)
$replacements['\\'.$from] = '['.$from.']';
}

return strtr($format, $replacements);
return strtr($format ?? '', $replacements);
}
}
4 changes: 2 additions & 2 deletions modules/system/partials/_settings_menu_items.htm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
$context = System\Classes\SettingsManager::instance()->getContext();

$collapsedGroups = explode('|',
isset($_COOKIE['sidenav_treegroupStatus']) ? $_COOKIE['sidenav_treegroupStatus'] : null
isset($_COOKIE['sidenav_treegroupStatus']) ? $_COOKIE['sidenav_treegroupStatus'] : ''
);

?>
Expand All @@ -28,4 +28,4 @@ <h3><?= e(trans($category)) ?></h3>
</ul>
</li>
<?php endforeach ?>
</ul>
</ul>