Skip to content

Comments

Add "Send password reset email" button to backend users update page#723

Merged
LukeTowers merged 4 commits intowintercms:developfrom
prsuhas:send-password-reset-button
Oct 13, 2022
Merged

Add "Send password reset email" button to backend users update page#723
LukeTowers merged 4 commits intowintercms:developfrom
prsuhas:send-password-reset-button

Conversation

@prsuhas
Copy link
Contributor

@prsuhas prsuhas commented Oct 2, 2022

Fix for issue #654

Added "Send password reset email" button to backend users update page.

@LukeTowers I have re-used the existing Password reset logic present in modules/backend/controllers/Auth.php file. Should I create a helper function to remove code duplication ?

@LukeTowers
Copy link
Member

@prsuhas no, that's fine, we can leave the code copy-pasted for now. Can you add a screenshot of what the new button looks like please?

@LukeTowers LukeTowers added enhancement PRs that implement a new feature or substantial change needs response Issues/PRs where a maintainer is awaiting a response from the submitter labels Oct 2, 2022
@prsuhas
Copy link
Contributor Author

prsuhas commented Oct 3, 2022

@prsuhas no, that's fine, we can leave the code copy-pasted for now. Can you add a screenshot of what the new button looks like please?

Please find below screenshot

Screenshot from 2022-10-03 09-53-54

Pushed the review changes too.

@LukeTowers LukeTowers added Status: Completed and removed needs response Issues/PRs where a maintainer is awaiting a response from the submitter labels Oct 3, 2022
@LukeTowers LukeTowers added this to the v1.2.1 milestone Oct 3, 2022
@prsuhas prsuhas changed the title Added "Send password reset email" button to backend users update page Add "Send password reset email" button to backend users update page Oct 3, 2022
@LukeTowers LukeTowers merged commit 2fc9997 into wintercms:develop Oct 13, 2022
LukeTowers added a commit that referenced this pull request Oct 24, 2022
…d-themes-luke

* commit '966edea734a0e330f19ebe2547a1332ed39cb907':
  Set pivot data when initially syncing the relationship
  Update jobs tables to support Laravel 9 (#730)
  Add migrate to list of protected commands (#733)
  Add "Send password reset email" button to backend users update page (#723)
  Adjust descriptor for local event
  Change event doc to test new event functionality in Docs plugin
  Removed NPX from webpack bin call (#728)
  Add test case for getParentData method in AJAX framework
  Recompile Snowboard
  Allow for custom AJAX error responses to be passed through handlers
  Allow detached AJAX request to be called with 2 params
  Improve IDE knowledge of the PluginBase object
  Fix support for data-request-parent
LukeTowers added a commit that referenced this pull request Oct 26, 2022
* develop:
  Set pivot data when initially syncing the relationship (#739)
  Added CLI signature to mix:list command
  Fix Navigation Manager unit test
  Update jobs tables to support Laravel 9 (#730)
  Add migrate to list of protected commands (#733)
  Add "Send password reset email" button to backend users update page (#723)
  Adjust descriptor for local event
  Change event doc to test new event functionality in Docs plugin
  Removed NPX from webpack bin call (#728)
  Add test case for getParentData method in AJAX framework
  Recompile Snowboard
  Allow for custom AJAX error responses to be passed through handlers
  Allow detached AJAX request to be called with 2 params
  Improve IDE knowledge of the PluginBase object
  Fix support for data-request-parent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement PRs that implement a new feature or substantial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants