Skip to content

Comments

Update failed_jobs table to add missing uuid column.#730

Merged
LukeTowers merged 6 commits intowintercms:developfrom
ericp-mrel:fix/add-uuid-column-failed-jobs
Oct 20, 2022
Merged

Update failed_jobs table to add missing uuid column.#730
LukeTowers merged 6 commits intowintercms:developfrom
ericp-mrel:fix/add-uuid-column-failed-jobs

Conversation

@ericp-mrel
Copy link
Contributor

This also updates the payload and exception columns to be inline with default the laravel migration.

Fixes #696

Let me know if you'd prefer I remove the updates to the payload and exception columns.

Eric Pfeiffer added 2 commits October 14, 2022 17:13
This also updates the `payload` and `exception` columns to be inline with default the laravel migration.
@LukeTowers
Copy link
Member

@ericp-mrel looks good to me, were you able to test it running locally?

@ericp-mrel
Copy link
Contributor Author

@LukeTowers

I've tested it locally with a blank Winter CMS project, created a job class that fails so it gets added to the failed_jobs table and is working correctly. I also tested by importing a database dump from one of my other projects (Winter CMS v1.1) and ran the migrations against that database and the migrations run successfully for existing projects as well.

@LukeTowers LukeTowers added maintenance PRs that fix bugs, are translation changes or make only minor changes Status: Revision Needed labels Oct 17, 2022
@LukeTowers LukeTowers added this to the v1.2.1 milestone Oct 17, 2022
@LukeTowers LukeTowers merged commit dc70c90 into wintercms:develop Oct 20, 2022
@ericp-mrel ericp-mrel deleted the fix/add-uuid-column-failed-jobs branch October 20, 2022 14:40
LukeTowers added a commit that referenced this pull request Oct 24, 2022
…d-themes-luke

* commit '966edea734a0e330f19ebe2547a1332ed39cb907':
  Set pivot data when initially syncing the relationship
  Update jobs tables to support Laravel 9 (#730)
  Add migrate to list of protected commands (#733)
  Add "Send password reset email" button to backend users update page (#723)
  Adjust descriptor for local event
  Change event doc to test new event functionality in Docs plugin
  Removed NPX from webpack bin call (#728)
  Add test case for getParentData method in AJAX framework
  Recompile Snowboard
  Allow for custom AJAX error responses to be passed through handlers
  Allow detached AJAX request to be called with 2 params
  Improve IDE knowledge of the PluginBase object
  Fix support for data-request-parent
LukeTowers added a commit that referenced this pull request Oct 26, 2022
* develop:
  Set pivot data when initially syncing the relationship (#739)
  Added CLI signature to mix:list command
  Fix Navigation Manager unit test
  Update jobs tables to support Laravel 9 (#730)
  Add migrate to list of protected commands (#733)
  Add "Send password reset email" button to backend users update page (#723)
  Adjust descriptor for local event
  Change event doc to test new event functionality in Docs plugin
  Removed NPX from webpack bin call (#728)
  Add test case for getParentData method in AJAX framework
  Recompile Snowboard
  Allow for custom AJAX error responses to be passed through handlers
  Allow detached AJAX request to be called with 2 params
  Improve IDE knowledge of the PluginBase object
  Fix support for data-request-parent
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance PRs that fix bugs, are translation changes or make only minor changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing uuid field on failed_jobs table

2 participants