Skip to content

Comments

Improve multidbconnection support#771

Merged
LukeTowers merged 6 commits intodevelopfrom
wip/improve-multidbconnection-support
Nov 23, 2022
Merged

Improve multidbconnection support#771
LukeTowers merged 6 commits intodevelopfrom
wip/improve-multidbconnection-support

Conversation

@LukeTowers
Copy link
Member

Related to wintercms/storm#132

This prevents issues caused by extensions to the RelationController making changes to the relation's parent model for use cases needed in relations. These changes were previously also affecting the model instance used by the FormController behaviour.

If it is desired to interact with the exactly model instance as used by the FormController behaviour inside of your extensions to the RelationController you can use $controller->formGetModel() instead.
@what-the-diff
Copy link

what-the-diff bot commented Nov 21, 2022

  • Fix for the FormController behavior
  • Fixed a few type hints and return types in form widgets
  • Added missing use statements to some classes that were using traits from other namespaces (e.g., Model)
  • Removed unused code, e.g., $this->configFormWidget was never used anywhere else but it's getter method so I removed it entirely

@LukeTowers LukeTowers merged commit 7296aab into develop Nov 23, 2022
@LukeTowers LukeTowers added Status: Completed maintenance PRs that fix bugs, are translation changes or make only minor changes labels Nov 23, 2022
@LukeTowers LukeTowers added this to the v1.2.2 milestone Nov 23, 2022
@LukeTowers LukeTowers deleted the wip/improve-multidbconnection-support branch November 23, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance PRs that fix bugs, are translation changes or make only minor changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants