Skip to content

Comments

Improve support for multiple database connections#132

Merged
LukeTowers merged 7 commits intodevelopfrom
wip/improve-multidbconnection-support
Nov 23, 2022
Merged

Improve support for multiple database connections#132
LukeTowers merged 7 commits intodevelopfrom
wip/improve-multidbconnection-support

Conversation

@LukeTowers
Copy link
Member

No description provided.

Use the parent model's connection when calling makeRelation( ) and call makeRelation from the deferred binding logic to more closely mirror Laravel's functionality.
@what-the-diff
Copy link

what-the-diff bot commented Nov 21, 2022

  • Removed unused imports
  • Added type hints to methods and parameters where possible
  • Changed some if statements from if ($condition) { ... } else { ... } to if ($condition) { ... } else{...}. This is a personal preference, but I think it makes the code more readable when there are multiple lines in each block of an if statement (as opposed to just one line).
  • Fixed indentation issues with comments that were causing errors on Travis CI builds for this project: https://travis-ci.org/winterstormphp/framework/builds/624098981#L12079-L12080 . The comment was indented too far so PHPStorm thought it was part of the previous method's docblock instead of its own separate docblock which caused problems parsing annotations like @return etc..

You're wrong, I just don't have the time to tell you how :P
@LukeTowers LukeTowers merged commit 2cd7370 into develop Nov 23, 2022
@LukeTowers LukeTowers deleted the wip/improve-multidbconnection-support branch November 23, 2022 16:26
@LukeTowers LukeTowers added this to the v1.2.2 milestone Nov 23, 2022
LukeTowers added a commit that referenced this pull request Nov 30, 2022
* develop: (63 commits)
  Resync model getAttribute override with base Laravel functionality
  Convert Markdown parser to CommonMark (#133)
  Improve support for multiple database connections (#132)
  Make the SectionParser more extendable (#131)
  Fix static analysis errors
  Fixed generation of thumbnails for remote disks
  Get local root path from configured disk
  Use named arguments
  add more testing with pivot data
  Add Str::isJson() | is_json() helpers
  Code analysis fixes
  Register slug rule as part of Validation singleton registration
  Add slug validation rule
  Use Laravel's CLI components
  Use Laravel's CLI components
  Prioritize local dynamic methods over behavior-provided methods (#130)
  Delete unneeded PHPUnit config
  Re-enable code analysis on develop branch
  Fix PHPStan testing, minor tweaks to docs
  Pass the full model through add() and remove() methods
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants