Prioritize local dynamic methods over behavior-provided methods#130
Merged
LukeTowers merged 2 commits intodevelopfrom Oct 24, 2022
Merged
Prioritize local dynamic methods over behavior-provided methods#130LukeTowers merged 2 commits intodevelopfrom
LukeTowers merged 2 commits intodevelopfrom
Conversation
This prioritizes locally added dynamic methods over public methods that have been defined in behaviors that are implemented on the object.
bennothommo
reviewed
Oct 24, 2022
bennothommo
approved these changes
Oct 24, 2022
Member
|
I've been dreaming of this for the past 6 years! |
Member
Author
|
It's still not going to help with the problem of overriding methods that already exist on the class or its ancestors directly but at least now we can override methods that are defined on the behaviors |
LukeTowers
added a commit
that referenced
this pull request
Nov 30, 2022
* develop: (63 commits) Resync model getAttribute override with base Laravel functionality Convert Markdown parser to CommonMark (#133) Improve support for multiple database connections (#132) Make the SectionParser more extendable (#131) Fix static analysis errors Fixed generation of thumbnails for remote disks Get local root path from configured disk Use named arguments add more testing with pivot data Add Str::isJson() | is_json() helpers Code analysis fixes Register slug rule as part of Validation singleton registration Add slug validation rule Use Laravel's CLI components Use Laravel's CLI components Prioritize local dynamic methods over behavior-provided methods (#130) Delete unneeded PHPUnit config Re-enable code analysis on develop branch Fix PHPStan testing, minor tweaks to docs Pass the full model through add() and remove() methods ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prioritizes locally added dynamic methods over public methods that have been defined in behaviors that are implemented on the object.