Skip to content

Comments

Make the SectionParser more extendable#131

Merged
LukeTowers merged 1 commit intodevelopfrom
wip/extenable-section-parser
Nov 16, 2022
Merged

Make the SectionParser more extendable#131
LukeTowers merged 1 commit intodevelopfrom
wip/extenable-section-parser

Conversation

@LukeTowers
Copy link
Member

Allows for extending the SectionParser class to swap out how various sections are prepared for storage and parsed from storage (example, custom SectionParser that uses YAML in the settings section)

Allows for extending the SectionParser class to swap out how various sections are prepared for storage and parsed from storage (example, custom SectionParser that uses YAML in the settings section)
@what-the-diff
Copy link

what-the-diff bot commented Nov 16, 2022

  • The render() method was split into three methods:
    • renderSettings(): renders the settings section of a CMS object as file content.
    • renderCode(): renders the code section of a CMS object as file content.
    • renderMarkup(): renders the markup section of a CMS object as file content.

@LukeTowers LukeTowers merged commit 6bc2a46 into develop Nov 16, 2022
@LukeTowers LukeTowers deleted the wip/extenable-section-parser branch November 16, 2022 17:13
LukeTowers added a commit that referenced this pull request Nov 30, 2022
* develop: (63 commits)
  Resync model getAttribute override with base Laravel functionality
  Convert Markdown parser to CommonMark (#133)
  Improve support for multiple database connections (#132)
  Make the SectionParser more extendable (#131)
  Fix static analysis errors
  Fixed generation of thumbnails for remote disks
  Get local root path from configured disk
  Use named arguments
  add more testing with pivot data
  Add Str::isJson() | is_json() helpers
  Code analysis fixes
  Register slug rule as part of Validation singleton registration
  Add slug validation rule
  Use Laravel's CLI components
  Use Laravel's CLI components
  Prioritize local dynamic methods over behavior-provided methods (#130)
  Delete unneeded PHPUnit config
  Re-enable code analysis on develop branch
  Fix PHPStan testing, minor tweaks to docs
  Pass the full model through add() and remove() methods
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant