Skip to content

i18n(de): update concepts/why-astro.mdx#10072

Merged
jsparkdev merged 5 commits into
withastro:mainfrom
trueberryless:con-why
Nov 22, 2024
Merged

i18n(de): update concepts/why-astro.mdx#10072
jsparkdev merged 5 commits into
withastro:mainfrom
trueberryless:con-why

Conversation

@trueberryless
Copy link
Copy Markdown
Contributor

Description (required)

  • update concepts/why-astro.mdx

Related issues & labels (optional)

@github-actions github-actions Bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Nov 20, 2024
@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 20, 2024

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9f3fc94
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/67404ca53806260008d869d6
😎 Deploy Preview https://deploy-preview-10072--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Nov 20, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
de/concepts/why-astro.mdx Localization changed, will be marked as complete.
de/guides/migrate-to-astro/from-create-react-app.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@jsparkdev
Copy link
Copy Markdown
Member

Thank you @trueberryless !

I would like to request two modifications.

  1. please make the arrows on lines 57 and 58 the same as the other arrows.
  2. the last paragraph of the heading Entwicklerorientiert doesn't seem to exist, please add it.

@jsparkdev
Copy link
Copy Markdown
Member

On line 54 of from-create-react-app.mdx, there is a link to /de/concepts/why-astro/#inhaltsfokussiert. However, in the modified file, there is no corresponding heading, resulting in an error.

@trueberryless
Copy link
Copy Markdown
Contributor Author

All links should be fixed now! 😊

Copy link
Copy Markdown
Member

@jsparkdev jsparkdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good. LGTM!

@jsparkdev jsparkdev merged commit 30a969c into withastro:main Nov 22, 2024
@trueberryless trueberryless deleted the con-why branch November 22, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants