Skip to content

[why-astro]#5428

Merged
sarah11918 merged 20 commits into
mainfrom
why-astro-new
Nov 20, 2023
Merged

[why-astro]#5428
sarah11918 merged 20 commits into
mainfrom
why-astro-new

Conversation

@sarah11918
Copy link
Copy Markdown
Member

Description (required)

Revamped "Why Astro?" page after Sarah <> Fred messaging discussions.

@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Nov 20, 2023 6:11pm

Copy link
Copy Markdown
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a huge revamp @sarah11918, amazing job. I left you a couple of suggestions and I would love to hear what you think.

Comment thread src/content/docs/en/concepts/why-astro.mdx Outdated
Comment thread src/content/docs/en/concepts/why-astro.mdx Outdated
Comment thread src/content/docs/en/concepts/why-astro.mdx Outdated
Comment thread src/content/docs/en/concepts/why-astro.mdx Outdated
Comment thread src/content/docs/en/concepts/why-astro.mdx Outdated
Comment thread src/content/docs/en/concepts/why-astro.mdx Outdated
Comment thread src/content/docs/en/concepts/why-astro.mdx Outdated
Comment thread src/content/docs/en/concepts/why-astro.mdx Outdated
Comment thread src/content/docs/en/concepts/why-astro.mdx Outdated
**Astro was designed for building content-rich websites.** This includes marketing sites, publishing sites, documentation sites, blogs, portfolios, landing pages, community sites, and ecommerce sites. If you have content to show, it needs to reach your reader quickly.

By contrast, most modern web frameworks are designed for building *web applications*. These frameworks work best for building more complex, application-like experiences in the browser: logged-in admin dashboards, inboxes, social networks, todo lists, and even native-like applications like [Figma](https://figma.com/) and [Ping](https://ping.gg/).
By contrast, most modern web frameworks were designed for building *web applications*. These frameworks excel at building more complex, application-like experiences in the browser: logged-in admin dashboards, inboxes, social networks, todo lists, and even native-like applications like [Figma](https://figma.com/) and [Ping](https://ping.gg/). However, they often struggle to provide great performance when you need it most.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The final sentence - However, they often struggle to provide ... most
Regular Astro Docs Reader POV: Its good 👍
Twitter Hot Take POV: I kinda feel bad reading it and I would not like it in my feed as well

I have never seen any Framework Docs mentioning how a certain third party product can struggle during times of need

Note: This is a subjective opinion and I don't think my suggestion here would make any difference for better but I want to just talk about it given Fred and Theo(ping.gg creator) have some good content over Youtube & Twitter afaik

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let's try to avoid hot takes here! I do want a however, of some kind. Something that implies: if a thing was built for that stuff, then why would you expect it to excel at the other stuff? Does a change like... "However with that complexity, they CAN struggle to provide great performance when delivering your content." feel any different to you?

Copy link
Copy Markdown
Member

@at-the-vr at-the-vr Nov 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will follow up on this in next 8-10 hours (its midnight at my place)
From my PoV the PR is a big 👍 (GitHub Inbox going crazy already)

Copy link
Copy Markdown
Member

@at-the-vr at-the-vr Nov 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how to mark a comment resolved in GitHub so I will just approve the PR for the better (will do that tomorrow for sure)

Copy link
Copy Markdown
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great, left a few comments.

Comment thread src/content/docs/en/concepts/why-astro.mdx Outdated
Comment thread src/content/docs/en/concepts/why-astro.mdx Outdated
Comment thread src/content/docs/en/concepts/why-astro.mdx Outdated
Comment thread src/content/docs/en/concepts/why-astro.mdx Outdated
Comment thread src/content/docs/en/concepts/why-astro.mdx Outdated
Comment thread src/content/docs/en/guides/migrate-to-astro/from-docusaurus.mdx Outdated
Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
Comment thread src/content/docs/en/concepts/why-astro.mdx Outdated
@at-the-vr
Copy link
Copy Markdown
Member

Final remarks before Approving

Huge revamp 🥇, thanks to Yan and Dreyfus for making my job easier 👍

Copy link
Copy Markdown
Member

@at-the-vr at-the-vr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@FredKSchott
Copy link
Copy Markdown
Member

Talked with Sarah via Discord and committed my edits directly to the PR. Mainly focused on bringing the intro together into a concise, connected story: Astro is X. It is special because Y. If you are Z, Astro is for you.

Love this new page, especially the new value around developer experience!

Comment thread src/content/docs/en/concepts/why-astro.mdx Outdated
Comment thread src/content/docs/en/concepts/why-astro.mdx Outdated
Comment thread src/content/docs/en/concepts/why-astro.mdx Outdated
Copy link
Copy Markdown
Member

@FredKSchott FredKSchott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I can give a deeper read later this week to look for specific edits and suggestions if it would help, but also don't let me block / consider this my official +1!

Thanks for all of your work on this Sarah! Love the new section on developer experience!

@sarah11918 sarah11918 merged commit bb4b0dd into main Nov 20, 2023
@sarah11918 sarah11918 deleted the why-astro-new branch November 20, 2023 18:16
yanthomasdev added a commit that referenced this pull request Feb 1, 2024
* i18n(it): update why-astro.mdx

The file `why-astro.mdx` has been updated to align with the English language documentation based on this commits #5428

* Fix links

---------

Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Apr 4, 2025
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants