i18n(ja): Update why-astro.mdx#5951
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
kyosuke
reviewed
Dec 27, 2023
Contributor
kyosuke
left a comment
There was a problem hiding this comment.
@morinokami 最新版の英語と比べて、レビューしました。全体的に丁寧にわかりやすく翻訳されていると思いました。
細かな気になった点にコメントしていますが、IMOなものがほとんどなので、みていただいて取り込まなくても構いません。
Co-authored-by: Kyosuke Nakamura <kyosuke@users.noreply.github.com>
Co-authored-by: Kyosuke Nakamura <kyosuke@users.noreply.github.com>
Co-authored-by: Kyosuke Nakamura <kyosuke@users.noreply.github.com>
Co-authored-by: Kyosuke Nakamura <kyosuke@users.noreply.github.com>
Co-authored-by: Kyosuke Nakamura <kyosuke@users.noreply.github.com>
Member
Author
|
@kyosuke レビューいただきありがとうございました!提示していただいた内容が全体的に適切そうだと思ったため、取り込ませていただきました🙏 |
kyosuke
approved these changes
Dec 27, 2023
Contributor
kyosuke
left a comment
There was a problem hiding this comment.
@morinokami 反映、ありがとうございます!原文も翻訳も素晴らしいドキュメントだと思います。
LGTM!
ematipico
pushed a commit
that referenced
this pull request
Jan 26, 2024
Co-authored-by: Kyosuke Nakamura <kyosuke@users.noreply.github.com> Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (required)
Related issues & labels (optional)