Skip to content

i18n(ja): Update why-astro.mdx#5951

Merged
sarah11918 merged 8 commits into
withastro:mainfrom
morinokami:i18n-ja-why-astro-0
Dec 27, 2023
Merged

i18n(ja): Update why-astro.mdx#5951
sarah11918 merged 8 commits into
withastro:mainfrom
morinokami:i18n-ja-why-astro-0

Conversation

@morinokami
Copy link
Copy Markdown
Member

Description (required)

Related issues & labels (optional)

  • Closes #
  • Suggested label:

@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Dec 27, 2023 0:46am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) Visit Preview Dec 27, 2023 0:46am

@github-actions github-actions Bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Dec 26, 2023
Copy link
Copy Markdown
Contributor

@kyosuke kyosuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@morinokami 最新版の英語と比べて、レビューしました。全体的に丁寧にわかりやすく翻訳されていると思いました。

細かな気になった点にコメントしていますが、IMOなものがほとんどなので、みていただいて取り込まなくても構いません。

Comment thread src/content/docs/ja/concepts/why-astro.mdx Outdated
Comment thread src/content/docs/ja/concepts/why-astro.mdx Outdated
Comment thread src/content/docs/ja/concepts/why-astro.mdx Outdated
Comment thread src/content/docs/ja/concepts/why-astro.mdx Outdated
Comment thread src/content/docs/ja/concepts/why-astro.mdx Outdated
morinokami and others added 5 commits December 27, 2023 10:15
Co-authored-by: Kyosuke Nakamura <kyosuke@users.noreply.github.com>
Co-authored-by: Kyosuke Nakamura <kyosuke@users.noreply.github.com>
Co-authored-by: Kyosuke Nakamura <kyosuke@users.noreply.github.com>
Co-authored-by: Kyosuke Nakamura <kyosuke@users.noreply.github.com>
Co-authored-by: Kyosuke Nakamura <kyosuke@users.noreply.github.com>
@morinokami
Copy link
Copy Markdown
Member Author

@kyosuke レビューいただきありがとうございました!提示していただいた内容が全体的に適切そうだと思ったため、取り込ませていただきました🙏

@morinokami morinokami requested a review from kyosuke December 27, 2023 03:09
Copy link
Copy Markdown
Contributor

@kyosuke kyosuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@morinokami 反映、ありがとうございます!原文も翻訳も素晴らしいドキュメントだと思います。

LGTM!

@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Dec 27, 2023
@sarah11918 sarah11918 merged commit 8a370d8 into withastro:main Dec 27, 2023
ematipico pushed a commit that referenced this pull request Jan 26, 2024
Co-authored-by: Kyosuke Nakamura <kyosuke@users.noreply.github.com>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants