Skip to content

Convert slug to id in Typescript docs page#10148

Merged
sarah11918 merged 2 commits into
withastro:mainfrom
emma-sg:patch-1
Dec 4, 2024
Merged

Convert slug to id in Typescript docs page#10148
sarah11918 merged 2 commits into
withastro:mainfrom
emma-sg:patch-1

Conversation

@emma-sg
Copy link
Copy Markdown
Contributor

@emma-sg emma-sg commented Dec 3, 2024

Description (required)

Updates the code example in the Infer getStaticPaths() types section of the Typescript page in the docs to use id rather than slug to reflect the Astro v5 updates to the Content Layer.

Discord username: emma.cafe

Related issues & labels (optional)

  • Suggested label: code snippet update

@emma-sg
Convert slug to id in Typescript docs page
8dfbc18 
Reflects Content Collections → Content Layer migration
@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 3, 2024 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 62af9be
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/6750e0a64103210008d1803a
😎 Deploy Preview https://deploy-preview-10148--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Dec 3, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/typescript.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Dec 3, 2024

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳.

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@sarah11918 sarah11918 added code snippet update Updates a code sample: typo, outdated code etc. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! labels Dec 4, 2024
sarah11918
sarah11918 approved these changes Dec 4, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Emma! Thanks for spotting this and taking the time to contribute! We appreciate the effort, and are happy to welcome you to Team Docs! 🥳

@emma-sg
Copy link
Copy Markdown
Contributor Author

emma-sg commented Dec 4, 2024

Yay, thank you Sarah!

@sarah11918 sarah11918 merged commit be90a76 into withastro:main Dec 4, 2024
@emma-sg emma-sg mentioned this pull request Dec 5, 2024
Merged
sarah11918 added a commit that referenced this pull request Dec 5, 2024
@emma-sg @sarah11918
Hotfix for #10148: fix indentation in ^? comments (#10197)
3dbf37d 
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
@emma-sg emma-sg deleted the patch-1 branch December 5, 2024 15:59
@jsparkdev jsparkdev mentioned this pull request Dec 6, 2024
Closed
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Dec 13, 2024
@ArmandPhilippot
i18n(fr): update guides/typescript.mdx
fd8cf0c 
See withastro#9240, withastro#10148 and withastro#10197
@ArmandPhilippot ArmandPhilippot mentioned this pull request Dec 13, 2024
Merged
thomasbnt added a commit that referenced this pull request Dec 14, 2024
@ArmandPhilippot @thomasbnt
i18n(fr): update guides/typescript.mdx (#10366)
667566d 
* i18n(fr): update `guides/typescript.mdx`

See #9240, #10148 and #10197

* translate code snippet comments

Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>

* fix comment in code snippet

---------

Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>
@Nin3lee Nin3lee mentioned this pull request Dec 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees

No one assigned

Labels

code snippet update Updates a code sample: typo, outdated code etc. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@emma-sg @astrobot-houston @sarah11918