Skip to content

Hotfix for #10148: fix indentation in ^? comments#10197

Merged
sarah11918 merged 2 commits into
withastro:mainfrom
emma-sg:10148-spacing-hotfix
Dec 5, 2024
Merged

Hotfix for #10148: fix indentation in ^? comments#10197
sarah11918 merged 2 commits into
withastro:mainfrom
emma-sg:10148-spacing-hotfix

Conversation

@emma-sg
Copy link
Copy Markdown
Contributor

@emma-sg emma-sg commented Dec 5, 2024

Description (required)

Quick fix for misaligned // ^? typescript comments in the code example I updated in #10148.

Before After
Screenshot 2024-12-04 at 7 47 07 PM Screenshot 2024-12-04 at 7 47 47 PM

Related issues & labels (optional)

@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 5, 2024

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7240dce
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/6751ca1e79d80e0008dff5a6
😎 Deploy Preview https://deploy-preview-10197--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Dec 5, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/typescript.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@sarah11918
Copy link
Copy Markdown
Member

Hi Emma, I'm not sure what the problem you're fixing is? The alignment looks exactly the same to me! What are you fixing here?

@emma-sg
Copy link
Copy Markdown
Contributor Author

emma-sg commented Dec 5, 2024

Oh, should have been more specific — the ^ currently points to the “a” in params, it should point to the “p”. I’d just used one too many spaces!

@sarah11918
Copy link
Copy Markdown
Member

Ah, gotcha! Was so hard to tell! Thanks for the clarification, and the fix! 💪

@sarah11918 sarah11918 added code snippet update Updates a code sample: typo, outdated code etc. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! labels Dec 5, 2024
@sarah11918 sarah11918 merged commit 3dbf37d into withastro:main Dec 5, 2024
@emma-sg emma-sg deleted the 10148-spacing-hotfix branch December 5, 2024 15:58
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Dec 13, 2024
thomasbnt added a commit that referenced this pull request Dec 14, 2024
* i18n(fr): update `guides/typescript.mdx`

See #9240, #10148 and #10197

* translate code snippet comments

Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>

* fix comment in code snippet

---------

Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code snippet update Updates a code sample: typo, outdated code etc. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants