Skip to content

Installation : content loader configuration#10187

Merged
sarah11918 merged 4 commits into
withastro:mainfrom
SebSept:patch-1
Dec 4, 2024
Merged

Installation : content loader configuration#10187
sarah11918 merged 4 commits into
withastro:mainfrom
SebSept:patch-1

Conversation

@SebSept
Copy link
Copy Markdown
Contributor

@SebSept SebSept commented Dec 4, 2024

Description

Missing configuration needed to finish mdx integration.

The theme I use did use mdx by default, so I had to do this change.
It worth mentioning this point, I guess.

@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 4, 2024

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 713c5ef
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/6750e229e4ac830008526511
😎 Deploy Preview https://deploy-preview-10187--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Dec 4, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/integrations-guide/mdx.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@astrobot-houston
Copy link
Copy Markdown
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳.

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @SebSept ! Thank you for contributing to the docs! I'm glad you figured out how to update your own theme, and appreciate you sharing that.

The code wasn't quite correct however, so I've updated it for our new content collections. And, I don't think I would put this in the section for configuring the integration since this is instead about using MDX in your Astro project.

See what you think about my proposed changes! If you saw this in docs, would this have helped you with your project? Do you think this is helpful to readers?

@SebSept
Copy link
Copy Markdown
Contributor Author

SebSept commented Dec 4, 2024

Thanks for the corrections ! Important point is the import statements missing.

In fact, this not my own theme but astropaper, found on the site : https://astro.build/themes/details/astropaper/ (first free result with request blog)

If you saw this in docs, would this have helped you with your project? Do you think this is helpful to readers?

I double checked the documentation, tried some changes in the contents, rerun yarn installation, rerun the integration process, etc. I also wonder if it was related to the new version. Finally, It took me a long time to figure that the problem was in a file not mentioned in the documentation. I'm new to Astro, so this is normal.
This is just my personal case, but for sure, having this information could have helped me a lot.
Maybe it's not relevant for the rest of us, maybe most themes include mdx files by default, I don't know.

@sarah11918
Copy link
Copy Markdown
Member

sarah11918 commented Dec 4, 2024

Well, we do want docs to be helpful! And I don't think having this extra little section hurts anyone. If you say you would have found it a helpful reminder, then I think a section like you proposed is a good reminder that you CAN for sure use MDX in your content collections, even if you had to install MDX yourself.

So let's put this in docs and maybe it will help more people! 🙌 Welcome to Team Docs! 🥳

Comment thread src/content/docs/en/guides/integrations-guide/mdx.mdx Outdated
@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! labels Dec 4, 2024
@sarah11918 sarah11918 merged commit bf5086b into withastro:main Dec 4, 2024
@SebSept SebSept deleted the patch-1 branch December 5, 2024 06:09
thomasbnt pushed a commit to thomasbnt/docs that referenced this pull request Dec 11, 2024
… at L101 in mdx.mdx file not working)

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
thomasbnt added a commit to thomasbnt/docs that referenced this pull request Dec 11, 2024
… at L101 in mdx.mdx file not working)

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
thomasbnt added a commit that referenced this pull request Dec 11, 2024
* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `guides/integrations-guide/*`from #9240

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Err tab

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Remove <reference... L116 in netlify

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Remove "côté serveur" L14 in solid-js

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Remove "squoosh" L190 in vercel

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Remove "<reference..." L389 in vercel

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): remove `await` from `import.meta.glob()` from #10332

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): content loader configuration from #10187 (the link at L101 in mdx.mdx file not working)

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): content loader configuration from #10187 (the link at L101 in mdx.mdx file not working)

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Note for myself, mdx.mdx line 101 : When content-collections will be updated, put this text with good link

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): L237 in vercel.mdx "#astrorequest"

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

---------

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants