Skip to content

i18n(fr): Update guides/integrations-guide/*from #9240#10328

Merged
thomasbnt merged 41 commits into
withastro:mainfrom
thomasbnt:i18n-fr-update-v5-guides-integrations-guide
Dec 11, 2024
Merged

i18n(fr): Update guides/integrations-guide/*from #9240#10328
thomasbnt merged 41 commits into
withastro:mainfrom
thomasbnt:i18n-fr-update-v5-guides-integrations-guide

Conversation

@thomasbnt
Copy link
Copy Markdown
Member

@thomasbnt thomasbnt commented Dec 10, 2024

Description (required)

Update guides/integrations-guide/* from #9240

Note

> Check Links: src/content/docs/fr/guides/integrations-guide/vercel.mdx#L237
Broken fragment link in src/content/docs/fr/guides/integrations-guide/vercel.mdx, line 237: The linked page does not contain a fragment with the name "#request"

Need to edit the reference/api-reference/#request and guides/content-collections/#defining-the-collection-loader (wrong link in mdx.mdx L101.)

Important

🚨🚨🚨
Note for myself, mdx.mdx line 101 : When content-collections will be updated by #10145, https://github.com/withastro/docs/pull/10328/files#r1880456439, put this text with good link.
🚨🚨🚨

Related issues & labels (optional)

  • Suggested label: i18n

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
@github-actions github-actions Bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Dec 10, 2024
@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 10, 2024

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b70d492
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/6759b8c75e5b1a0008150f69
😎 Deploy Preview https://deploy-preview-10328--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Dec 10, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
fr/guides/integrations-guide/alpinejs.mdx Localization changed, will be marked as complete.
fr/guides/integrations-guide/cloudflare.mdx Localization changed, will be marked as complete.
fr/guides/integrations-guide/db.mdx Localization changed, will be marked as complete.
fr/guides/integrations-guide/deno.mdx Localization changed, will be marked as complete.
fr/guides/integrations-guide/index.mdx Localization changed, will be marked as complete.
fr/guides/integrations-guide/lit.mdx Localization changed, will be marked as complete.
fr/guides/integrations-guide/markdoc.mdx Localization changed, will be marked as complete.
fr/guides/integrations-guide/mdx.mdx Localization changed, will be marked as complete.
fr/guides/integrations-guide/netlify.mdx Localization changed, will be marked as complete.
fr/guides/integrations-guide/node.mdx Localization changed, will be marked as complete.
fr/guides/integrations-guide/partytown.mdx Localization changed, will be marked as complete.
fr/guides/integrations-guide/preact.mdx Localization changed, will be marked as complete.
fr/guides/integrations-guide/prefetch.mdx Localization changed, will be marked as complete.
fr/guides/integrations-guide/react.mdx Localization changed, will be marked as complete.
fr/guides/integrations-guide/sitemap.mdx Localization changed, will be marked as complete.
fr/guides/integrations-guide/solid-js.mdx Localization changed, will be marked as complete.
fr/guides/integrations-guide/svelte.mdx Localization changed, will be marked as complete.
fr/guides/integrations-guide/tailwind.mdx Localization changed, will be marked as complete.
fr/guides/integrations-guide/vercel.mdx Localization changed, will be marked as complete.
fr/guides/integrations-guide/vue.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
@thomasbnt
Copy link
Copy Markdown
Member Author

Note

Check Links: src/content/docs/fr/guides/integrations-guide/vercel.mdx#L237
Broken fragment link in src/content/docs/fr/guides/integrations-guide/vercel.mdx, line 237: The linked page does not contain a fragment with the name "#request"

Need to edit the reference/api-reference/#request.

Copy link
Copy Markdown
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed a few changes and unfortunately I can't add suggestions there... 😅

  • netlify.mdx: you forgot to remove a <reference ... l116
  • solidjs.mdx: you forgot to remove a côté serveur l14
  • vercel.mdx: you forgot to remove a squoosh l190 and a <reference ... l389

@ArmandPhilippot
Copy link
Copy Markdown
Member

Otherwise for the broken link you can revert the change and we'll update all those links while updating api-reference.mdx... this is what I've done with some merged PR. Thanks to linkcheck we can retrieve all those links even if they are marked as up to date. 😉

ArmandPhilippot and others added 4 commits December 10, 2024 18:16
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Comment thread src/content/docs/fr/guides/integrations-guide/mdx.mdx
thomasbnt and others added 3 commits December 11, 2024 14:53
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
… at L101 in mdx.mdx file not working)

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
… at L101 in mdx.mdx file not working)

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
@thomasbnt
Copy link
Copy Markdown
Member Author

Warning

Little error link from the file fr/guides/content-collections/#defining-the-collection-loader. Need update for content-collections

@ArmandPhilippot
Copy link
Copy Markdown
Member

Hum... we have a problem here. The PR for content-collections needs integrations-guide/markdoc.mdx to be up to date... another circular dependency! 😅 See: #10145

What we could do to make this PR mergeable: remove the link to content-collection in mdx, I already have a big alert "Notes for myself" in #10145, I can add another one to add back this link...
The PR also depends on the tutorial update (I'm on it), then it should be mergeable. So the link won't be away for long...

What do you think about it?

If this solution suits you, you also need to revert the link to api-reference in vercel.mdx (another broken link), we'll update it at the same time as api-reference.mdx.

…s will be updated, put this text with good link

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
@thomasbnt
Copy link
Copy Markdown
Member Author

thomasbnt commented Dec 11, 2024

Hum... we have a problem here. The PR for content-collections needs integrations-guide/markdoc.mdx to be up to date... another circular dependency! 😅 See: #10145

What we could do to make this PR mergeable: remove the link to content-collection in mdx, I already have a big alert "Notes for myself" in #10145, I can add another one to add back this link... The PR also depends on the tutorial update (I'm on it), then it should be mergeable. So the link won't be away for long...

What do you think about it?

If this solution suits you, you also need to revert the link to api-reference in vercel.mdx (another broken link), we'll update it at the same time as api-reference.mdx.

Important

🚨🚨🚨
Note for myself, mdx.mdx line 101 : When content-collections will be updated https://github.com/withastro/docs/pull/10328/files#r1880456439, put this text with good link.
🚨🚨🚨

Comment on lines +101 to +103
{/*
Pour inclure des fichiers MDX dans une collection de contenus, assurez-vous que votre [chargeur de collection](/fr/guides/content-collections/#defining-the-collection-loader) est configuré pour charger du contenu à partir de fichiers `.mdx` :
*/}
Copy link
Copy Markdown
Member Author

@thomasbnt thomasbnt Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

🚨🚨🚨
Note for myself, mdx.mdx line 101 : When content-collections will be updated https://github.com/withastro/docs/pull/10328/files#r1880456439, put this text with good link.
🚨🚨🚨

Removing comment code after content-collections is merged. Create a new PR for that.

Copy link
Copy Markdown
Member Author

@thomasbnt thomasbnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See message

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Copy link
Copy Markdown
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thomasbnt thomasbnt merged commit d757ebe into withastro:main Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants