Skip to content

fix: remove image().refine from a code snippet in guides/images.mdx#10202

Merged
sarah11918 merged 1 commit into
withastro:mainfrom
ArmandPhilippot:fix/update-image-refine-example
Dec 5, 2024
Merged

fix: remove image().refine from a code snippet in guides/images.mdx#10202
sarah11918 merged 1 commit into
withastro:mainfrom
ArmandPhilippot:fix/update-image-refine-example

Conversation

@ArmandPhilippot
Copy link
Copy Markdown
Member

Description (required)

Since v5, we cannot use refine() with the image() helper, so I updated an outdated example in guides/images.mdx.

I also slightly reworded the sentence above the code snippet because I believe this is no longer validated with Zod. But happy to revert or to reword if I'm wrong.

Related issues & labels (optional)

@astrobot-houston
Copy link
Copy Markdown
Contributor

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/images.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 5, 2024

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 500ef97
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/675189a9fa56d30008e5937c
😎 Deploy Preview https://deploy-preview-10202--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for keeping us honest! 💪

@sarah11918 sarah11918 added code snippet update Updates a code sample: typo, outdated code etc. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! labels Dec 5, 2024
@sarah11918 sarah11918 merged commit 1ccdc96 into withastro:main Dec 5, 2024
@ArmandPhilippot ArmandPhilippot deleted the fix/update-image-refine-example branch December 5, 2024 11:38
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Dec 17, 2024
yanthomasdev added a commit that referenced this pull request Dec 17, 2024
See #9240, #10149 and #10202

Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code snippet update Updates a code sample: typo, outdated code etc. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using Zod's refine with image() for content collections

3 participants