Skip to content

Add cross-reference link in Image component docs to UI framework usage#10149

Merged
sarah11918 merged 2 commits into
withastro:mainfrom
colemilne54:5.0-main
Dec 4, 2024
Merged

Add cross-reference link in Image component docs to UI framework usage#10149
sarah11918 merged 2 commits into
withastro:mainfrom
colemilne54:5.0-main

Conversation

@colemilne54
Copy link
Copy Markdown
Contributor

Description

This PR adds a helpful navigation link in the Image component documentation that points readers to the section about passing Astro image components as children to UI framework components. This small enhancement helps users more easily discover the proper way to use Image components within UI frameworks.

Same change as #10101 but re-submitting as instructed by @sarah11918 now that 5.0 is out!

@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 3, 2024

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 20e0167
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/6750ded3477c7f00089ffac7
😎 Deploy Preview https://deploy-preview-10149--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Dec 3, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/images.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Copy Markdown
Contributor

@SnowDingo SnowDingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @colemilne54, for your contribution.

I reviewed your changes, and I found no errors/bugs overall.
Therefore, I approved it👍

Best Regards,
SnowDingo

Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much both for your patience, and for coming back, @colemilne54 ! 🙌

Now it is my esteemed pleasure to officially welcome you to Team Docs! 😄

@sarah11918 sarah11918 added typo/link/grammar - quick fix! Quick fix for a link, typo, grammar/syntax error etc. Doesn't significantly change meaning of text. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! labels Dec 4, 2024
@sarah11918 sarah11918 merged commit 6166672 into withastro:main Dec 4, 2024
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Dec 17, 2024
yanthomasdev added a commit that referenced this pull request Dec 17, 2024
See #9240, #10149 and #10202

Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! typo/link/grammar - quick fix! Quick fix for a link, typo, grammar/syntax error etc. Doesn't significantly change meaning of text.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants