Skip to content

fix: indent & line highlighting in guides/internationalization.mdx#10269

Merged
yanthomasdev merged 2 commits into
withastro:mainfrom
ArmandPhilippot:fix/guides-internationalization-nitpicks
Dec 7, 2024
Merged

fix: indent & line highlighting in guides/internationalization.mdx#10269
yanthomasdev merged 2 commits into
withastro:mainfrom
ArmandPhilippot:fix/guides-internationalization-nitpicks

Conversation

@ArmandPhilippot
Copy link
Copy Markdown
Member

Description (required)

Fixes a few nitpicks in guides/internationalization.mdx:

  • in the domains section, the highlighting for inserted lines should be restricted to the domains property
  • in the code snippet of Custom locale paths, the indent for codes was wrong
  • in the Create localized folders section, missing backticks for a route (all other routes on the page are wrapped with backticks)

Related issues & labels (optional)

  • Suggested label: code snippet update

@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 7, 2024

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 8353d7b
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/6754568d86b6430008e0cc02
😎 Deploy Preview https://deploy-preview-10269--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Dec 7, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/internationalization.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Comment thread src/content/docs/en/guides/internationalization.mdx Outdated
@ArmandPhilippot ArmandPhilippot marked this pull request as ready for review December 7, 2024 14:12
Copy link
Copy Markdown
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@yanthomasdev yanthomasdev merged commit a4a40ac into withastro:main Dec 7, 2024
@ArmandPhilippot ArmandPhilippot deleted the fix/guides-internationalization-nitpicks branch December 7, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants