Conversation
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Thank you, Martin! I will ask for more reviews since I mostly crafted this draft originally! |
ArmandPhilippot
left a comment
There was a problem hiding this comment.
The content looks great to me! But, I left two comments regarding the form: these are nitpicking so I'm approving and you're free to ignore them. 😄
What bothers me is that the intro is getting longer so I left some thoughts to help make scanning the page easier I think (but maybe it's not the best solution).
On other pages, the intro is often 1 or 2 paragraphs. So if it's the page's intro, people might be tempted to just skip it until the next heading while there is valuable information here.
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
|
@ArmandPhilippot See what you think of this reordering to accommodate a heading! |
ArmandPhilippot
left a comment
There was a problem hiding this comment.
Nice job with the reordering, I think this looks great! 🙌🏽
|
Adding the subheading was a great idea, I really like it this way! |
sarah11918
left a comment
There was a problem hiding this comment.
omg I finally got all the checks to pass, @martrapp !! 😅
I'm happy with this if you are, so it's yours to merge when you're satisfied!
|
We might need a Lunaria directive because of changes in Edit: |
|
Read the final version once more. I think this turned out really great. It already started off well, and now it got even better. I am fully on board with it. And I am happy that our users now may have a clearer sense of their options. Thank you so much for putting such care into it! |
Anything I have to be aware of before merging, @ArmandPhilippot? |
|
@martrapp You just need to put |
Description (required)
Adding the introduction from #10902
Related issues & labels (optional)
Closes #10902