Skip to content

new intro for view transitions#11889

Merged
martrapp merged 9 commits into
mainfrom
mt/vta
Jun 21, 2025
Merged

new intro for view transitions#11889
martrapp merged 9 commits into
mainfrom
mt/vta

Conversation

@martrapp
Copy link
Copy Markdown
Member

Description (required)

Adding the introduction from #10902

Related issues & labels (optional)

  • Closes #
  • Suggested label:

Closes #10902

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Jun 15, 2025

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/actions.mdx Source changed, localizations will be marked as outdated.
en/guides/view-transitions.mdx Source changed, localizations will be marked as outdated.
pl/guides/actions.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 15, 2025

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 4ab1ce6
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/685696191d897000086c5e63
😎 Deploy Preview https://deploy-preview-11889--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sarah11918
Copy link
Copy Markdown
Member

Thank you, Martin! I will ask for more reviews since I mostly crafted this draft originally!

@sarah11918 sarah11918 added the improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) label Jun 17, 2025
@sarah11918 sarah11918 requested a review from yanthomasdev June 17, 2025 19:25
Copy link
Copy Markdown
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content looks great to me! But, I left two comments regarding the form: these are nitpicking so I'm approving and you're free to ignore them. 😄

What bothers me is that the intro is getting longer so I left some thoughts to help make scanning the page easier I think (but maybe it's not the best solution).
On other pages, the intro is often 1 or 2 paragraphs. So if it's the page's intro, people might be tempted to just skip it until the next heading while there is valuable information here.

Comment thread src/content/docs/en/guides/view-transitions.mdx Outdated
Comment thread src/content/docs/en/guides/view-transitions.mdx Outdated
sarah11918 and others added 2 commits June 18, 2025 06:42
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Comment thread src/content/docs/en/guides/view-transitions.mdx Outdated
@sarah11918
Copy link
Copy Markdown
Member

@ArmandPhilippot See what you think of this reordering to accommodate a heading!

Copy link
Copy Markdown
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job with the reordering, I think this looks great! 🙌🏽

@martrapp
Copy link
Copy Markdown
Member Author

Adding the subheading was a great idea, I really like it this way!

Comment thread src/content/docs/en/guides/view-transitions.mdx
Comment thread src/content/docs/en/guides/view-transitions.mdx Outdated
@github-actions github-actions Bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Jun 19, 2025
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

omg I finally got all the checks to pass, @martrapp !! 😅

I'm happy with this if you are, so it's yours to merge when you're satisfied!

@ArmandPhilippot
Copy link
Copy Markdown
Member

ArmandPhilippot commented Jun 19, 2025

We might need a Lunaria directive because of changes in pl/guides/actions.mdx, right?

Edit: @lunaria-track:src/content/docs/en/**/*.mdx should work I think?

@martrapp
Copy link
Copy Markdown
Member Author

Read the final version once more. I think this turned out really great. It already started off well, and now it got even better. I am fully on board with it. And I am happy that our users now may have a clearer sense of their options.

Thank you so much for putting such care into it!

@martrapp
Copy link
Copy Markdown
Member Author

We might need a Lunaria directive because of changes in pl/guides/actions.mdx, right?

Anything I have to be aware of before merging, @ArmandPhilippot?

@ArmandPhilippot
Copy link
Copy Markdown
Member

ArmandPhilippot commented Jun 19, 2025

@martrapp You just need to put @lunaria-track:src/content/docs/en/**/*.mdx in the commit description before merging and the pl file should be ignored (ie. not marked as up-to-date when it is not)!

@martrapp martrapp merged commit 6257b7f into main Jun 21, 2025
10 checks passed
@martrapp martrapp deleted the mt/vta branch June 21, 2025 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add some hint with pros and cons why the <ClientRouter /> is not the only approach to view transitions.

4 participants