Skip to content

Clean up <Tab> component usage#1769

Merged
sarah11918 merged 3 commits into
withastro:mainfrom
mrienstra:patch-2
Oct 21, 2022
Merged

Clean up <Tab> component usage#1769
sarah11918 merged 3 commits into
withastro:mainfrom
mrienstra:patch-2

Conversation

@mrienstra
Copy link
Copy Markdown
Contributor

@mrienstra mrienstra commented Oct 10, 2022

What kind of changes does this PR include?

  • Changes to the docs site code

Description

  • What does this PR change? Give us a brief description.
    • New <JavascriptFlavorTabs> component
    • Use existing <PackageManagerTabs> where relevant
    • Remove unnecessary import Tabs

Preview links:

- New JavascriptFlavorTabs component
- Use existing PackageManagerTabs where relevent
- Remove unnecessary import
@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 10, 2022

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2c47993
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/6352dfc6d0c6180008cb41e1
😎 Deploy Preview https://deploy-preview-1769--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sarah11918 sarah11918 added the hacktoberfest-accepted Mark a PR as accepted to contribute towards Hacktoberfest label Oct 11, 2022
@sarah11918 sarah11918 added the site improvement Some thing that improves the website functionality - ask @delucis for help! label Oct 13, 2022
@sarah11918
Copy link
Copy Markdown
Member

This looks great, @mrienstra! Thanks for waiting as we caught up to it!

And, I took the opportunity to fix something weird with the <Prism /> component documentation while you were right there. I don't know how it ended up as a "note"? 😅 At any rate, fixed! 🥳

@sarah11918 sarah11918 merged commit 3a1f4da into withastro:main Oct 21, 2022
@mrienstra mrienstra deleted the patch-2 branch October 21, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted Mark a PR as accepted to contribute towards Hacktoberfest site improvement Some thing that improves the website functionality - ask @delucis for help!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants