Adding hashes to links#1729
Conversation
and fixing random stuff
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Whoops, removed |
|
Find: Replace: Find: Replace: PS: Happy to back out /es/, /pt-br/ & /zh-cn/ changes, my thinking was that it would be permissible as I didn't change any translated copy. |
|
Hi @mrienstra, lots of stuff here! I appreciate how much effort you're putting into all kinds of docs improvements! This is a LOT for one PR, and not something we'd normally encourage putting all together like this. Partly because some people might be appropriate to look at some, but not worry about all of it. And protip: if the title of the PR doesn't describe what's in here, that's a clue that it's probably more than we want to address at once! ;) At the very least, could I ask you to separate out into separate PRs:
A PR like this makes a lot of simple quick fixes actually harder to get through, as any one of the maintainers could quickly handle one of these changes, and the title can be a reasonable expectation of who is up for reviewing knowing what the PR contains in terms of content and scope. When that alternative exists, PRs like this just don't make a lot of sense for our community workflow. Remember, PRs are freeeee! 🥳 So please do in future try to keep changes contained to the PR title. You can decide whether you'd like to keep this one open for one of the PRs, and remove a bunch of the changes, or whether you'd like to close this one and start fresh with individual PRs for everything. |
|
This PR was broken into the following: |
What kind of changes does this PR include?
This PR began with adding hashes to links.
Along the way, I found & fixed / improved:
extendDefaultPlugins: trueto 2 examples, to reduce surprising side effects that may otherwise occur when blindly copying code from examples.npm i-->npm install(for consistency).import Tabsfrom 2 pagesTabstoPackageManagerTabsPackageManagerTabsto 1 page.reference/adapter-referenceto other adapter docs.#adding-an-adapter, but also because I think it will scan better.During the same editing session, I edited 4 auto-generated files:
main...mrienstra:docs:placeholder-1
I'll have to open another PR for those changes, the sources in question being: