Skip to content

npm i --> npm install#1772

Merged
sarah11918 merged 2 commits into
withastro:mainfrom
mrienstra:patch-3
Oct 14, 2022
Merged

npm i --> npm install#1772
sarah11918 merged 2 commits into
withastro:mainfrom
mrienstra:patch-3

Conversation

@mrienstra
Copy link
Copy Markdown
Contributor

What kind of changes does this PR include?

  • Minor content fixes (broken links, typos, etc.)

Description

In all code samples within ./src/pages/en/**/*.md, I changed:

npm i --> npm install
pnpm i --> pnpm install

For consistency, in line with how it most often appears in the docs.

Find:

\b(p?npm) i 

Replace:

$1 install 

For consistency, bring in line with how it most often appears in the docs.
@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 10, 2022

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 64e53a9
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/6349d1f27a242100084bf65d
😎 Deploy Preview https://deploy-preview-1772--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sarah11918 sarah11918 added the hacktoberfest-accepted Mark a PR as accepted to contribute towards Hacktoberfest label Oct 11, 2022
Copy link
Copy Markdown
Contributor

@aFuzzyBear aFuzzyBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mrienstra for this, a very surgical string replacement, 👍
But I must ask a larger question, why was npm i used over npm install I would defer to @sarah11918 for guidance on this,

@mrienstra
Copy link
Copy Markdown
Contributor Author

mrienstra commented Oct 12, 2022

Good question! For context, stats, before the changes in this PR (./src/pages/en/**/*.md only):

\b(p?npm) i 

--> 19 results in 11 files

`\b(p?npm) install 

--> 50 results in 31 files

@sarah11918 sarah11918 added the improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) label Oct 13, 2022
@sarah11918
Copy link
Copy Markdown
Member

Thanks, @mrienstra! Appreciate you splitting these out so I can more easily tackle the quick ones as I have time! 🚀

@sarah11918 sarah11918 merged commit 44c4259 into withastro:main Oct 14, 2022
@mrienstra mrienstra deleted the patch-3 branch October 14, 2022 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted Mark a PR as accepted to contribute towards Hacktoberfest improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants