Use extendDefaultPlugins in more code samples#1777
Merged
Conversation
Plus more extendDefaultPlugins crosslinking
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
sarah11918
added
the
hacktoberfest-accepted
Closed
sarah11918
added
the
improve or update documentation
delucis
reviewed
Oct 21, 2022
Member
delucis
left a comment
delucis
left a comment
There was a problem hiding this comment.
Thanks for this @mrienstra! For the most part I think these are helpful changes, but one I think we probably want to revert to avoid over complicating an example where extendDefaultPlugins isn’t strictly speaking relevant.
delucis
approved these changes
Oct 21, 2022
Member
delucis
left a comment
delucis
left a comment
There was a problem hiding this comment.
@sarah11918 suggested I just go ahead and finish this off to get this merged — thanks again @mrienstra! 🙌
This was referenced Oct 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of changes does this PR include?
Description
Use
extendDefaultPlugins: truein more code samples. There were a few that I didn't add it to.My thought process when evaluating each one was basically: Would I expect this code sample to drop the default plugins as a side effect of adding a new plugin? Or, will I likely be carefully considering the behavior of the code sample, such that I am likely to understand that it drops the default plugins?
Another motivation for these changes is to reduce the likelihood of new users blinding copying these code samples, then being confused as to why they can no longer use GitHub-flavored Markdown.
Plus more extendDefaultPlugins cross-linking (minor). One indentation fix.
Preview links: