Skip to content

ci: update integration docs#1886

Merged
delucis merged 1 commit into
mainfrom
ci/docgen-integrations
Oct 25, 2022
Merged

ci: update integration docs#1886
delucis merged 1 commit into
mainfrom
ci/docgen-integrations

Conversation

@astrobot-houston
Copy link
Copy Markdown
Contributor

This PR is auto-generated by a nightly GitHub action to update the individual integration pages from the integration READMEs in withastro/astro.

@astrobot-houston astrobot-houston added the ci Automated PRs created by CI, or PRs about automation - ask @delucis for help! label Oct 22, 2022
@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 22, 2022

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit cb186d1
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/6357d114824e5d0008c3a9d6
😎 Deploy Preview https://deploy-preview-1886--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@delucis
Copy link
Copy Markdown
Member

delucis commented Oct 22, 2022

Oops — didn’t notice when I was reviewing #1777 @mrienstra but one of those files was the MDX integration README that lives in the main Astro repo: https://github.com/withastro/astro/blob/main/packages/integrations/mdx/README.md

We’ll need to make these changes there instead.

@mrienstra
Copy link
Copy Markdown
Contributor

@delucis, d'oh! 🤦 Guess I forgot to scroll up to the top to check, my bad. I think I might still have a few changes leftover from #1729 of the same nature (within .md files pulled automatically from /astro to /docs).

@delucis
Copy link
Copy Markdown
Member

delucis commented Oct 25, 2022

Going to merge these now they actually have new content in them even though we lose @mrienstra’s fixes.

@mrienstra Feel free to add your fixes from #1777 to the astro repo when you have a moment!

@delucis delucis merged commit aa3db45 into main Oct 25, 2022
@delucis delucis deleted the ci/docgen-integrations branch October 25, 2022 13:23
@mrienstra
Copy link
Copy Markdown
Contributor

@delucis, there seems to be a wee bit of a mystery!

The anchor I added in #1777

... appears to have been there since that paragraph was added

... and that paragraph hasn't been changed since, according to blame.

Very weird! Happy to dig deeper, but thought I'd run it past you first, in case the cause is obvious to you.

Aww nuts, I can't resist a good mystery, I'm diving in!
🤿 🐟 🌊

@mrienstra
Copy link
Copy Markdown
Contributor

mrienstra commented Oct 25, 2022

Here's the trail:

Edit: confirmed that scripts/generate-integration-pages.ts is stripping that hash, finding out where exactly next...

Edit 2: found it! scripts/generate-integration-pages.ts#L186

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Automated PRs created by CI, or PRs about automation - ask @delucis for help!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants