Skip to content

docgen:integrations: don't strip hashes from links#1919

Merged
delucis merged 1 commit into
withastro:mainfrom
mrienstra:patch-11
Oct 25, 2022
Merged

docgen:integrations: don't strip hashes from links#1919
delucis merged 1 commit into
withastro:mainfrom
mrienstra:patch-11

Conversation

@mrienstra
Copy link
Copy Markdown
Contributor

What kind of changes does this PR include?

  • Changes to the docs site code (specifically to scripts/generate-integration-pages.ts, which is called by pnpm run docgen:integrations)

Description

  • I noticed that a link hash was disappearing somewhere between withastro/astro and withastrodocs`:
    - https://docs.astro.build/en/reference/configuration-reference/#markdownextenddefaultplugins
    +                         /en/reference/configuration-reference/
  • Tracked down the source of the issue, this PR fixes it (confirmed locally).
  • Also made a very minor change to an unrelated regex in the same script, to reduce the chance of it erroneously matching in the future.
  • Tempting to figure out how to test this script, but I gather it will be retired sometime in the next few months.

@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 25, 2022

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 41d3afc
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/63583bbc2677880009b372e3
😎 Deploy Preview https://deploy-preview-1919--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Copy Markdown
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @mrienstra! I hadn’t realised these fragment links were getting stripped out — thanks for fixing.

@delucis delucis merged commit 3b439f3 into withastro:main Oct 25, 2022
@mrienstra mrienstra deleted the patch-11 branch October 25, 2022 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants