Skip to content

i18n(ja): Update astro-pages.mdx#2319

Merged
delucis merged 3 commits into
withastro:mainfrom
morinokami:i18n-ja-astro-pages
Jan 10, 2023
Merged

i18n(ja): Update astro-pages.mdx#2319
delucis merged 3 commits into
withastro:mainfrom
morinokami:i18n-ja-astro-pages

Conversation

@morinokami
Copy link
Copy Markdown
Member

What kind of changes does this PR include?

  • New or updated content
  • Translated content

Description

@github-actions github-actions Bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Jan 8, 2023
@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 8, 2023

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 10f46e2
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/63bd8217cbdecb0007e7c0ea
😎 Deploy Preview https://deploy-preview-2319--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Comment on lines -23 to +28
ページ間のリンクを張るには、HTMLの[`<a>`要素](https://developer.mozilla.org/ja/docs/Web/HTML/Element/a)をコンポーネントテンプレートに記述してください。

📚 [Astroのルーティング](/ja/core-concepts/routing/)について詳しくみる。

### ページ間のリンク

サイト内の別のページへとリンクを張るには、HTML標準の[`<a>`要素](https://developer.mozilla.org/ja/docs/Web/HTML/Element/a)をコンポーネントテンプレートに記述してください。

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2091 に対応しています。

Copy link
Copy Markdown
Contributor

@kyosuke kyosuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@morinokami レビューしました。全体的に細かい部分まで丁寧に修正されてると思いました。
このままでも問題ないと思いますが、小さな気づいた点だけコメントしてます。ご確認ください。

Comment thread src/pages/ja/core-concepts/astro-pages.mdx Outdated
Co-authored-by: Kyosuke <kyosuke@users.noreply.github.com>
@morinokami
Copy link
Copy Markdown
Member Author

@kyosuke レビューいただきありがとうございます、Suggestion をそのまま取り込ませてもらいました!

@morinokami morinokami requested a review from kyosuke January 9, 2023 07:01
Copy link
Copy Markdown
Contributor

@kyosuke kyosuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another page updated! Thanks @morinokami & @kyosuke 🚀

@delucis delucis merged commit 15706d2 into withastro:main Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants