Make more pages ready for translation#2855
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
yanthomasdev
added
the
i18n
github-actions
Bot
removed
the
i18n
delucis
left a comment
delucis
left a comment
There was a problem hiding this comment.
Impressive work here, @yan-thomas, thank you! Left one suggestion for the integration script.
| }; | ||
|
|
||
| // Add pages titles that should be marked as `i18nReady: false` as part of this array. | ||
| const translationBlacklist: string[] = []; |
There was a problem hiding this comment.
I’d suggest using “blocklist” instead of “blacklist” or a use-case specific name like i18nNotReadyIntegrations or something. We can also follow the same pattern as for #deprecatedIntegrations setting this inside IntegrationsPagesBuilder.
Maybe we want to block translation of Markdoc for now given it’s still very experimental?
There was a problem hiding this comment.
Fair points, I'll make these changes after arriving from college 🙌
|
Done @delucis! Let me know if you have any other comments/suggestions 🙌 |
dreyfus92
left a comment
dreyfus92
left a comment
There was a problem hiding this comment.
LGTM! ✅ We need to start shipping new translations.
4 participants
What kind of changes does this PR include?
Description
New 69 pages for our translators to enjoy! In this case, all the integrations, tutorial, CMS, and migration pages are now marked as
i18nReady: true.Preferably, we should merge #2852 before this one.