Update astro.build/asset links to live assets in repo#3016
Conversation
- Replace broken `https://astro.build/assets` links with new working links - Update alt texts
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
- Add `/public/assets` folder - Add all logo assets and rays / arc wallpaper to `/public/assets` - Update links to use `docs.astro.build`
astro.build/asset linksastro.build/asset links to live assets in repo
- Switch .webp to .png
- Rename folder to `assets` - Switch back to `webp` for arc and rays wallpapers
|
Hey @BryceRussell this is so helpful! But I looked through, and all the updated links (except arc and rays) on the docs pages are not pointing to the new images you added and they 404? Can you please double the link content on these? And, if we change the tutorial content, then we also need to change the tutorial repo (and all the branches properly) that mirrors the project that the tutorial builds. So we'll need to loop @delucis on that once these link examples here are figured out! |
- Fix image names to fit pathnames
|
Oops, thanks @sarah11918. I fixed the file names, so the images are now visible. For the changes to the tutorial page, should I make some PRs to |
|
Can the images for the posts in the tutorial be repeated? If they can't be repeated the tutorial repo has an extra 4th post not mentioned in docs that would require another image I think maybe it would be better to delete the 'rays' and 'arc' images entirely and repeat the full logo image for all 4 posts in the tutorial |
|
Let’s also sync with @ximenavf92 on this one as I know she was working on some assets for this! |
|
Ahh I see, awesome! I initially misread the issue when I submitted the PR so I tried shoehorning the public assets in to "save" it 😅. Having custom images will definitely work much better. |
|
In interest of getting this fixed so that people will stop telling us the tutorial image links won't work, I'd like to merge this! 😅 @BryceRussell can you make an issue in the actual tutorial blog example repo ( https://github.com/withastro/blog-tutorial-demo ) saying that we'll need to properly apply these changes throughout the various branches (or wait until we have permanent assets and do it then)? Then, ask either @delucis or @Jutanium how these changes need to be worked back in there and you could PR that repo, too! 🙌 (I'm OK if the tutorial content works, even if there's a bit of a delay in catching up the example repo.) |
|
I think it would be best to wait for dedicated assets so it doesn't have to be updated twice. (Unless there is a reason they cant be out of sync for a bit) |
|
Yeah, I personally think being out of sync is the lesser evil than the tutorial code not working when people copy it, so let's merge this now, and we'll update the repo (and these pages again) when we get resources! |
What kind of changes does this PR include?
Description
Closes #2975, #2865
/public/assetsfolder for assets hosted by docsarcandrayswallpapers to/public/assetshttps://astro.build/assetslinks withhttps://docs.astro.build/assetslinks