Skip to content

Update astro.build/asset links to live assets in repo#3016

Merged
sarah11918 merged 6 commits into
withastro:mainfrom
BryceRussell:fix-links
Apr 25, 2023
Merged

Update astro.build/asset links to live assets in repo#3016
sarah11918 merged 6 commits into
withastro:mainfrom
BryceRussell:fix-links

Conversation

@BryceRussell
Copy link
Copy Markdown
Member

@BryceRussell BryceRussell commented Apr 8, 2023

What kind of changes does this PR include?

  • Minor content fixes (broken links, typos, etc.)

Description

Closes #2975, #2865

  • Add /public/assets folder for assets hosted by docs
  • Add all four Astro logos plus the arc and rays wallpapers to /public/assets
  • Replace https://astro.build/assets links with https://docs.astro.build/assets links
  • Update alt texts

- Replace broken `https://astro.build/assets` links with new working links
- Update alt texts
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 8, 2023

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 3910012
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/64481b2cc11940000879ce0a
😎 Deploy Preview https://deploy-preview-3016--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

- Add `/public/assets` folder
- Add all logo assets and rays / arc wallpaper to `/public/assets`
- Update links to use `docs.astro.build`
@BryceRussell BryceRussell changed the title Fix broken astro.build/asset links Update astro.build/asset links to live assets in repo Apr 8, 2023
- Switch .webp to .png
- Rename folder to `assets`
- Switch back to `webp` for arc and rays wallpapers
@sarah11918
Copy link
Copy Markdown
Member

Hey @BryceRussell this is so helpful! But I looked through, and all the updated links (except arc and rays) on the docs pages are not pointing to the new images you added and they 404? Can you please double the link content on these?

And, if we change the tutorial content, then we also need to change the tutorial repo (and all the branches properly) that mirrors the project that the tutorial builds. So we'll need to loop @delucis on that once these link examples here are figured out!

@sarah11918 sarah11918 added typo/link/grammar - quick fix! Quick fix for a link, typo, grammar/syntax error etc. Doesn't significantly change meaning of text. tutorial Content/UI for the Build a Blog Tutorial labels Apr 10, 2023
- Fix image names to fit pathnames
@BryceRussell
Copy link
Copy Markdown
Member Author

BryceRussell commented Apr 10, 2023

Oops, thanks @sarah11918. I fixed the file names, so the images are now visible.

For the changes to the tutorial page, should I make some PRs to withastro/blog-tutorial-demo and its branches? Or is it easier for one of you to do it?

@BryceRussell
Copy link
Copy Markdown
Member Author

BryceRussell commented Apr 11, 2023

Can the images for the posts in the tutorial be repeated?

If they can't be repeated the tutorial repo has an extra 4th post not mentioned in docs that would require another image

I think maybe it would be better to delete the 'rays' and 'arc' images entirely and repeat the full logo image for all 4 posts in the tutorial

@delucis
Copy link
Copy Markdown
Member

delucis commented Apr 11, 2023

Let’s also sync with @ximenavf92 on this one as I know she was working on some assets for this!

@BryceRussell
Copy link
Copy Markdown
Member Author

BryceRussell commented Apr 11, 2023

Ahh I see, awesome! I initially misread the issue when I submitted the PR so I tried shoehorning the public assets in to "save" it 😅. Having custom images will definitely work much better.

@sarah11918
Copy link
Copy Markdown
Member

In interest of getting this fixed so that people will stop telling us the tutorial image links won't work, I'd like to merge this! 😅

@BryceRussell can you make an issue in the actual tutorial blog example repo ( https://github.com/withastro/blog-tutorial-demo ) saying that we'll need to properly apply these changes throughout the various branches (or wait until we have permanent assets and do it then)? Then, ask either @delucis or @Jutanium how these changes need to be worked back in there and you could PR that repo, too! 🙌

(I'm OK if the tutorial content works, even if there's a bit of a delay in catching up the example repo.)

@BryceRussell
Copy link
Copy Markdown
Member Author

BryceRussell commented Apr 25, 2023

I think it would be best to wait for dedicated assets so it doesn't have to be updated twice. (Unless there is a reason they cant be out of sync for a bit)

@sarah11918
Copy link
Copy Markdown
Member

Yeah, I personally think being out of sync is the lesser evil than the tutorial code not working when people copy it, so let's merge this now, and we'll update the repo (and these pages again) when we get resources!

@sarah11918 sarah11918 merged commit 8077640 into withastro:main Apr 25, 2023
@BryceRussell BryceRussell deleted the fix-links branch July 20, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tutorial Content/UI for the Build a Blog Tutorial typo/link/grammar - quick fix! Quick fix for a link, typo, grammar/syntax error etc. Doesn't significantly change meaning of text.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants