i18n(ja): Update endpoints.mdx#4518
Merged
Merged
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
Bot
added
the
i18n
kyosuke
reviewed
Sep 3, 2023
Contributor
kyosuke
left a comment
kyosuke
left a comment
There was a problem hiding this comment.
@morinokami 最新の英語版と比較してレビューしました。すべての変更がわかりやすく翻訳された上で反映されていました。個人的な意見になりますが、1つだけコメントをつけています。元のままでも問題ないかと思いますので、反映するかどうか含めてお任せします。
Co-authored-by: Kyosuke Nakamura <kyosuke@users.noreply.github.com>
Member
Author
|
@kyosuke ありがとうございます！確かに「任意の」よりも「どんな」のほうが誤解もなく硬すぎもせずいいですね（自分の癖で、硬い言葉を選びがちです...）。description の方もあわせて修正しました（こちらは英文をちゃんと確認すると Learn で始まっていたので、もとのままでもいいのですがついでに「説明します」を「学びます」に変えておきました）。 |
kyosuke
approved these changes
Sep 3, 2023
Contributor
kyosuke
left a comment
kyosuke
left a comment
There was a problem hiding this comment.
@morinokami 修正ありがとうございます。言葉選び、むずかしいですよね。
Learnに変わっていたの気づいていませんでした。学びますへの修正で良いと思います!
LGTM!
yanthomasdev
approved these changes
Sep 4, 2023
Member
yanthomasdev
left a comment
yanthomasdev
left a comment
There was a problem hiding this comment.
LGTM! Great work peeps 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of changes does this PR include?
Description
astro.build/assetlinks to live assets in repo #3016endpoints#4465